Skip to content

K
k3s
Commit f7dd4771 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #50536 from crimsonfaith91/mark-deprecated

Automatic merge from submit-queue (batch tested with PRs 50536, 50809, 50220, 50399, 50176) mark created-by annotation as deprecated **What this PR does / why we need it**: This PR marks created-by annotation as deprecated in code comments. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: xref #44407 **Special notes for your reviewer**: **Release note**: ```release-note The `kubernetes.io/created-by` annotation is now deprecated and will be removed in v1.9. Use [ControllerRef](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/controller-ref.md) instead to determine which controller, if any, owns an object. ```
parents 1eb04f6a 720f0419
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 0 deletions
pkg/api/annotation_key_constants.go
View file @ f7dd4771
...@@ -47,6 +47,8 @@ const ( ...@@ -47,6 +47,8 @@ const (
// CreatedByAnnotation represents the key used to store the spec(json) // CreatedByAnnotation represents the key used to store the spec(json)
// used to create the resource. // used to create the resource.
// This field is deprecated in favor of ControllerRef (see #44407).
// TODO(#50720): Remove this field in v1.9.
CreatedByAnnotation = "kubernetes.io/created-by" CreatedByAnnotation = "kubernetes.io/created-by"
// PreferAvoidPodsAnnotationKey represents the key of preferAvoidPods data (json serialized) // PreferAvoidPodsAnnotationKey represents the key of preferAvoidPods data (json serialized)
......
staging/src/k8s.io/api/core/v1/annotation_key_constants.go
View file @ f7dd4771
...@@ -47,6 +47,8 @@ const ( ...@@ -47,6 +47,8 @@ const (
// CreatedByAnnotation represents the key used to store the spec(json) // CreatedByAnnotation represents the key used to store the spec(json)
// used to create the resource. // used to create the resource.
// This field is deprecated in favor of ControllerRef (see #44407).
// TODO(#50720): Remove this field in v1.9.
CreatedByAnnotation = "kubernetes.io/created-by" CreatedByAnnotation = "kubernetes.io/created-by"
// PreferAvoidPodsAnnotationKey represents the key of preferAvoidPods data (json serialized) // PreferAvoidPodsAnnotationKey represents the key of preferAvoidPods data (json serialized)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment