Passing memory swap limit -1 by default. Docker remote API never check if memory

swap is enabled by kernel or not, instead by default to set the limit to memory * 2, and return API error 500 if swap is not enabled.

Passing memory swap limit -1 by default. Docker remote API never check if memory
f714020a · Dawn Chen · 636b40ff · f714020a
Commit f714020a authored Jun 05, 2015 by Dawn Chen
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

manager.go pkg/kubelet/dockertools/manager.go +4 -2

No files found.
--- a/pkg/kubelet/dockertools/manager.go
+++ b/pkg/kubelet/dockertools/manager.go
@@ -587,6 +587,7 @@ func (dm *DockerManager) runContainer(
 			Image:        container.Image,
 			// Memory and CPU are set here for older versions of Docker (pre-1.6).
 			Memory:     memoryLimit,
+			MemorySwap: -1,
 			CPUShares:  cpuShares,
 			WorkingDir: container.WorkingDir,
 			Labels:     labels,
@@ -637,8 +638,9 @@ func (dm *DockerManager) runContainer(
 		NetworkMode:  netMode,
 		IpcMode:      ipcMode,
 		// Memory and CPU are set here for newer versions of Docker (1.6+).
-		Memory:    memoryLimit,
+		Memory:     memoryLimit,
-		CPUShares: cpuShares,
+		MemorySwap: -1,
+		CPUShares:  cpuShares,
 	}
 	if len(opts.DNS) > 0 {
 		hc.DNS = opts.DNS