Commit f45e918b authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #35833 from apelisse/owners-pkg-controller

Automatic merge from submit-queue Curating Owners: pkg/controller cc @jsafrane @mikedanese @bprashanth @derekwaynecarr @thockin @saad-ali In an effort to expand the existing pool of reviewers and establish a two-tiered review process (first someone **lgtms** and then someone experienced in the project **approves**), we are adding new reviewers to existing owners files. ## If You Care About the Process: We did this by algorithmically figuring out who’s contributed code to the project and in what directories. Unfortunately, that doesn’t work perfectly: people that have made mechanical code changes (e.g change the copyright header across all directories) end up as reviewers in lots of places. Instead of using pure commit data, we generated an excessively large list of reviewers and pruned based on all time commit data, recent commit data and review data (number of PRs commented on). At this point we have a decent list of reviewers, but it needs one last pass for fine tuning. ## TLDR: As an owner of a sig/directory and a leader of the project, here’s what we need from you: 1. Use PR https://github.com/kubernetes/kubernetes/pull/35715 as an example. 2. The pull-request is made editable, please edit the OWNERS file to add the names of people that should be reviewing code in the future in the **reviewers** section. You probably do NOT need to modify the **approvers** section. 3. Notify me if you want some OWNERS file to be removed. Being an approver or reviewer of a parent directory makes you a reviewer/approver of the subdirectories too, so not all OWNERS files may be necessary. 4. Please use ALIAS if you want to use the same list of people over and over again (don't hesitate to ask me for help, or use the pull-request above as an example)
parents 6c059cb9 8ff3182f
assignees: approvers:
- bprashanth - bprashanth
- derekwaynecarr - derekwaynecarr
- mikedanese - mikedanese
reviewers:
- deads2k
reviewers:
- deads2k
- mikedanese
reviewers:
- mikedanese
- kargakis
- lukaszo
reviewers:
- janetkuo
- nikhiljindal
- kargakis
- mfojtik
reviewers:
- mml
- davidopp
- kargakis
- mwielgus
reviewers:
- bprashanth
- bowei
- MrHohn
- thockin
- mrubin
reviewers:
- caesarxuchao
- lavalamp
- deads2k
reviewers:
- derekwaynecarr
- caesarxuchao
- wojtek-t
- lavalamp
- deads2k
reviewers:
- erictune
- soltysh
reviewers:
- derekwaynecarr
- smarterclayton
reviewers:
- gmarek
- smarterclayton
- ingvagabund
- aveshagarwal
reviewers:
- foxish
- bprashanth
- smarterclayton
- janetkuo
- kargakis
reviewers:
- DirectXMan12
- mwielgus
- piosz
- jszczepkowski
- fgrzadkowski
reviewers:
- foxish
- gmarek
reviewers:
- caesarxuchao
- kargakis
- lavalamp
- bprashanth
reviewers:
- caesarxuchao
- kargakis
- lavalamp
- bprashanth
reviewers:
- derekwaynecarr
- deads2k
reviewers:
- gmarek
- wojtek-t
reviewers:
- erictune
- janetkuo
- soltysh
reviewers:
- bprashanth
- bowei
- MrHohn
- thockin
- mrubin
reviewers:
- saad-ali
- jsafrane
- jingxu97
- pmorie
- justinsb
- rootfs
assignees: approvers:
- saad-ali - saad-ali
assignees: approvers:
- jsafrane - jsafrane
- saad-ali - saad-ali
- thockin - thockin
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment