Commit f299a001 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #37558 from jayunit100/scheduler_log_spam

Automatic merge from submit-queue (batch tested with PRs 38076, 38137, 36882, 37634, 37558) [scheduler] Use V(10) for anything which may be O(N*P) logging Fixes #37014 This PR makes sure that logging statements which are capable of being called on a perNode / perPod basis (i.e. non essential ones that will just clog up logs at large scale) are at V(10) level. I dreamt of a levenstein filter that built a weak map of word frequencies and alerted once log throughput increased w/o varying information content.... but then I woke up and realized this is probably all we really need for now :)
parents 637a5703 7c94c518
...@@ -52,7 +52,7 @@ func (pfactory *PredicateMetadataFactory) GetMetadata(pod *v1.Pod, nodeNameToInf ...@@ -52,7 +52,7 @@ func (pfactory *PredicateMetadataFactory) GetMetadata(pod *v1.Pod, nodeNameToInf
matchingAntiAffinityTerms: matchingTerms, matchingAntiAffinityTerms: matchingTerms,
} }
for predicateName, precomputeFunc := range predicatePrecomputations { for predicateName, precomputeFunc := range predicatePrecomputations {
glog.V(4).Info("Precompute: %v", predicateName) glog.V(10).Info("Precompute: %v", predicateName)
precomputeFunc(predicateMetadata) precomputeFunc(predicateMetadata)
} }
return predicateMetadata return predicateMetadata
......
...@@ -417,7 +417,7 @@ func (c *VolumeZoneChecker) predicate(pod *v1.Pod, meta interface{}, nodeInfo *s ...@@ -417,7 +417,7 @@ func (c *VolumeZoneChecker) predicate(pod *v1.Pod, meta interface{}, nodeInfo *s
} }
nodeV, _ := nodeConstraints[k] nodeV, _ := nodeConstraints[k]
if v != nodeV { if v != nodeV {
glog.V(2).Infof("Won't schedule pod %q onto node %q due to volume %q (mismatch on %q)", pod.Name, node.Name, pvName, k) glog.V(10).Infof("Won't schedule pod %q onto node %q due to volume %q (mismatch on %q)", pod.Name, node.Name, pvName, k)
return false, []algorithm.PredicateFailureReason{ErrVolumeZoneConflict}, nil return false, []algorithm.PredicateFailureReason{ErrVolumeZoneConflict}, nil
} }
} }
......
...@@ -49,7 +49,7 @@ func calculateUnusedScore(requested int64, capacity int64, node string) int64 { ...@@ -49,7 +49,7 @@ func calculateUnusedScore(requested int64, capacity int64, node string) int64 {
return 0 return 0
} }
if requested > capacity { if requested > capacity {
glog.V(4).Infof("Combined requested resources %d from existing pods exceeds capacity %d on node %s", glog.V(10).Infof("Combined requested resources %d from existing pods exceeds capacity %d on node %s",
requested, capacity, node) requested, capacity, node)
return 0 return 0
} }
......
...@@ -53,7 +53,7 @@ func calculateUsedScore(requested int64, capacity int64, node string) int64 { ...@@ -53,7 +53,7 @@ func calculateUsedScore(requested int64, capacity int64, node string) int64 {
return 0 return 0
} }
if requested > capacity { if requested > capacity {
glog.V(4).Infof("Combined requested resources %d from existing pods exceeds capacity %d on node %s", glog.V(10).Infof("Combined requested resources %d from existing pods exceeds capacity %d on node %s",
requested, capacity, node) requested, capacity, node)
return 0 return 0
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment