Merge pull request #53364 from tcharding/kubectl-app

Automatic merge from submit-queue (batch tested with PRs 53204, 53364, 53559, 53589, 53088). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cmd: kubectl: remove golint_failures entry **What this PR does / why we need it**: `.golint_failures` currently has an entry for `cmd/kubectl/app`. We can lint this package and remove the entry. There is only one `golint` warning; comment on exported function Run should be of the form "Run..." Fix documentation comment and remove `cmd/kubectl/app` from `.golint_failures`. **Release note**: ```release-note NONE ``` /sig cli /kind cleanup

Merge pull request #53364 from tcharding/kubectl-app
efa17f5c · Kubernetes Submit Queue · GitHub · 9485ad2a · fa2de842 · efa17f5c
Commit efa17f5c authored Oct 11, 2017 by Kubernetes Submit Queue Committed by GitHub Oct 11, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

kubectl.go cmd/kubectl/app/kubectl.go +2 -0

.golint_failures hack/.golint_failures +0 -1

No files found.
--- a/cmd/kubectl/app/kubectl.go
+++ b/cmd/kubectl/app/kubectl.go
@@ -31,6 +31,8 @@ import (
 WARNING: this logic is duplicated, with minor changes, in cmd/hyperkube/kubectl.go
 Any salient changes here will need to be manually reflected in that file.
 */
+
+// Run runs the kubectl program (creates and executes a new cobra command).
 func Run() error {
 	logs.InitLogs()
 	defer logs.FlushLogs()

--- a/hack/.golint_failures
+++ b/hack/.golint_failures
@@ -7,7 +7,6 @@ cmd/kube-proxy/app
 cmd/kubeadm/app
 cmd/kubeadm/app/apis/kubeadm
 cmd/kubeadm/app/apis/kubeadm/v1alpha1
-cmd/kubectl/app
 cmd/kubelet/app
 cmd/kubelet/app/options
 cmd/kubemark