Merge pull request #74193 from xichengliudui/fixshellcheck19021802

hack/.shellcheck_failures

@@ -199,16 +199,12 @@
 ./test/images/volume/rbd/create_block.sh
 ./test/images/volume/rbd/mon.sh
 ./test/images/volume/rbd/osd.sh
-./test/integration/ipamperf/test-performance.sh
-./test/integration/scheduler_perf/test-performance.sh
 ./test/kubemark/common/util.sh
-./test/kubemark/configure-kubectl.sh
 ./test/kubemark/gce/util.sh
 ./test/kubemark/iks/shutdown.sh
 ./test/kubemark/iks/startup.sh
 ./test/kubemark/iks/util.sh
 ./test/kubemark/master-log-dump.sh
-./test/kubemark/pre-existing/util.sh
 ./test/kubemark/resources/start-kubemark-master.sh
 ./test/kubemark/run-e2e-tests.sh
 ./test/kubemark/start-kubemark.sh

test/integration/ipamperf/test-performance.sh

@@ -67,13 +67,13 @@ while getopts ":hdr:o:p:ca:k:n:m:l:" opt; do
   esac
 done
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/../../../
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/../../../
 source "${KUBE_ROOT}/hack/lib/init.sh"
 
 kube::golang::setup_env
 
-DIR_BASENAME=$(dirname "${BASH_SOURCE}")
-pushd ${DIR_BASENAME}
+DIR_BASENAME=$(dirname "${BASH_SOURCE[0]}")
+pushd "${DIR_BASENAME}"
 
 cleanup() {
   popd 2> /dev/null
@@ -87,5 +87,5 @@ kube::etcd::start
 
 # Running IPAM tests. It might take a long time.
 kube::log::status "performance test (IPAM) start"
-go test ${PROFILE_OPTS} -test.run=${RUN_PATTERN} -test.timeout=60m -test.short=false -v -args ${TEST_ARGS}
+go test "${PROFILE_OPTS}" -test.run="${RUN_PATTERN}" -test.timeout=60m -test.short=false -v -args "${TEST_ARGS}"
 kube::log::status "... IPAM tests finished."

test/integration/scheduler_perf/test-performance.sh

@@ -18,13 +18,13 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/../../../
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/../../../
 source "${KUBE_ROOT}/hack/lib/init.sh"
 
 kube::golang::setup_env
 
-DIR_BASENAME=$(dirname "${BASH_SOURCE}")
-pushd ${DIR_BASENAME}
+DIR_BASENAME=$(dirname "${BASH_SOURCE[0]}")
+pushd "${DIR_BASENAME}"
 
 cleanup() {
   popd 2> /dev/null

test/kubemark/configure-kubectl.sh

@@ -16,5 +16,5 @@
 
 # This script assumes that kubectl binary is present in PATH.
 kubectl config set-cluster hollow-cluster --server=http://localhost:8080 --insecure-skip-tls-verify=true
-kubectl config set-credentials $(whoami)
-kubectl config set-context hollow-context --cluster=hollow-cluster --user=$(whoami)
+kubectl config set-credentials "$(whoami)"
+kubectl config set-context hollow-context --cluster=hollow-cluster --user="$(whoami)"

test/kubemark/pre-existing/util.sh

@@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/../../..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/../../..
 
 source "${KUBE_ROOT}/test/kubemark/common/util.sh"
 
@@ -23,5 +23,5 @@ source "${KUBE_ROOT}/test/kubemark/common/util.sh"
 function execute-cmd-on-pre-existing-master-with-retries() {
   IP_WITHOUT_PORT=$(echo "${MASTER_IP}" | cut -f 1 -d ':') || "${MASTER_IP}"
 
-  RETRIES="${2:-1}" run-cmd-with-retries ssh kubernetes@"${IP_WITHOUT_PORT}" $1
+  RETRIES="${2:-1}" run-cmd-with-retries ssh kubernetes@"${IP_WITHOUT_PORT}" "${1}"
 }