Commit ee309f3c authored by James DeFelice's avatar James DeFelice

add TODOs

parent f445ead2
......@@ -16,4 +16,6 @@ limitations under the License.
// Package constraint exposes Marathon-like constraints for scheduling pods.
// Incomplete.
// TODO(jdef) We need better alignment between k8s-mesos and k8s scheduling
// constraints (read: a common constraints API).
package constraint
......@@ -326,6 +326,10 @@ func (k *kubeScheduler) doSchedule(task *podtask.T, err error) (string, error) {
return "", fmt.Errorf("task.offer assignment must be idempotent, task %+v: offer %+v", task, offer)
}
task.Offer = offer
//TODO(jdef) FillFromDetails currently allocates fixed (hardwired) cpu and memory resources for all
//tasks. This will be fixed once we properly integrate parent-cgroup support into the kublet-executor.
//For now we are completely ignoring the resources specified in the pod.
//see: https://github.com/mesosphere/kubernetes-mesos/issues/68
task.FillFromDetails(details)
if err := k.api.tasks().Update(task); err != nil {
offer.Release()
......
......@@ -153,6 +153,7 @@ func (t *T) BuildTaskInfo() *mesos.TaskInfo {
// Fill the Spec in the T, should be called during k8s scheduling,
// before binding.
// TODO(jdef): remove hardcoded values and make use of actual pod resource settings
func (t *T) FillFromDetails(details *mesos.Offer) error {
if details == nil {
//programming error
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment