Merge pull request #31485 from m1093782566/m109-proxy-fix-naming

pkg/proxy/healthcheck/api.go

@@ -33,12 +33,12 @@ func UpdateEndpoints(serviceName types.NamespacedName, endpointUids sets.String)
 	healthchecker.mutationRequestChannel <- req
 }
 
-func updateServiceListener(serviceName types.NamespacedName, listenPort int, addOrDelete bool) bool {
+func updateServiceListener(serviceName types.NamespacedName, listenPort int, add bool) bool {
 	responseChannel := make(chan bool)
 	req := &proxyListenerRequest{
 		serviceName:     serviceName,
 		listenPort:      uint16(listenPort),
-		add:             addOrDelete,
+		add:             add,
 		responseChannel: responseChannel,
 	}
 	healthchecker.listenerRequestChannel <- req
@@ -50,7 +50,7 @@ func AddServiceListener(serviceName types.NamespacedName, listenPort int) bool {
 	return updateServiceListener(serviceName, listenPort, true)
 }
 
-// DeleteServiceListener Request addition of a listener for a service's health check
+// DeleteServiceListener Request deletion of a listener for a service's health check
 func DeleteServiceListener(serviceName types.NamespacedName, listenPort int) bool {
 	return updateServiceListener(serviceName, listenPort, false)
 }

pkg/proxy/healthcheck/healthcheck.go

@@ -68,7 +68,7 @@ func (h *proxyHC) handleHealthCheckRequest(rw http.ResponseWriter, serviceName s
 	s, ok := h.serviceEndpointsMap.Get(serviceName)
 	if !ok {
 		glog.V(4).Infof("Service %s not found or has no local endpoints", serviceName)
-		sendHealthCheckResponse(rw, http.StatusServiceUnavailable, "No Service Endpoints Not Found")
+		sendHealthCheckResponse(rw, http.StatusServiceUnavailable, "No Service Endpoints Found")
 		return
 	}
 	numEndpoints := len(*s.(*serviceEndpointsList).endpoints)