Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
ecda7c60
Commit
ecda7c60
authored
Jul 09, 2016
by
Davanum Srinivas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allow empty value for env in kubectl run
Fixes #28734
parent
7f528c67
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
4 deletions
+9
-4
run.go
pkg/kubectl/run.go
+2
-2
run_test.go
pkg/kubectl/run_test.go
+7
-2
No files found.
pkg/kubectl/run.go
View file @
ecda7c60
...
@@ -934,7 +934,7 @@ func parseEnvs(envArray []string) ([]api.EnvVar, error) {
...
@@ -934,7 +934,7 @@ func parseEnvs(envArray []string) ([]api.EnvVar, error) {
}
}
name
:=
env
[
:
pos
]
name
:=
env
[
:
pos
]
value
:=
env
[
pos
+
1
:
]
value
:=
env
[
pos
+
1
:
]
if
len
(
name
)
==
0
||
len
(
value
)
==
0
{
if
len
(
name
)
==
0
{
return
nil
,
fmt
.
Errorf
(
"invalid env: %v"
,
env
)
return
nil
,
fmt
.
Errorf
(
"invalid env: %v"
,
env
)
}
}
if
len
(
validation
.
IsCIdentifier
(
name
))
!=
0
{
if
len
(
validation
.
IsCIdentifier
(
name
))
!=
0
{
...
@@ -955,7 +955,7 @@ func parseV1Envs(envArray []string) ([]v1.EnvVar, error) {
...
@@ -955,7 +955,7 @@ func parseV1Envs(envArray []string) ([]v1.EnvVar, error) {
}
}
name
:=
env
[
:
pos
]
name
:=
env
[
:
pos
]
value
:=
env
[
pos
+
1
:
]
value
:=
env
[
pos
+
1
:
]
if
len
(
name
)
==
0
||
len
(
validation
.
IsCIdentifier
(
name
))
!=
0
||
len
(
value
)
==
0
{
if
len
(
name
)
==
0
||
len
(
validation
.
IsCIdentifier
(
name
))
!=
0
{
return
nil
,
fmt
.
Errorf
(
"invalid env: %v"
,
env
)
return
nil
,
fmt
.
Errorf
(
"invalid env: %v"
,
env
)
}
}
envVar
:=
v1
.
EnvVar
{
Name
:
name
,
Value
:
value
}
envVar
:=
v1
.
EnvVar
{
Name
:
name
,
Value
:
value
}
...
...
pkg/kubectl/run_test.go
View file @
ecda7c60
...
@@ -858,8 +858,13 @@ func TestParseEnv(t *testing.T) {
...
@@ -858,8 +858,13 @@ func TestParseEnv(t *testing.T) {
envArray
:
[]
string
{
envArray
:
[]
string
{
"WITH_OUT_VALUES="
,
"WITH_OUT_VALUES="
,
},
},
expected
:
[]
api
.
EnvVar
{},
expected
:
[]
api
.
EnvVar
{
expectErr
:
true
,
{
Name
:
"WITH_OUT_VALUES"
,
Value
:
""
,
},
},
expectErr
:
false
,
test
:
"test case 3"
,
test
:
"test case 3"
,
},
},
{
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment