Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
ebe32557
Unverified
Commit
ebe32557
authored
May 01, 2019
by
Kubernetes Prow Robot
Committed by
GitHub
May 01, 2019
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #77297 from humblec/fakeclient-csi
Correct errors and remove unwanted code blocks .
parents
b219272a
4d56ab19
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
6 deletions
+5
-6
graph_builder.go
pkg/controller/garbagecollector/graph_builder.go
+1
-2
csi_plugin.go
pkg/volume/csi/csi_plugin.go
+1
-1
csi_plugin_test.go
pkg/volume/csi/csi_plugin_test.go
+2
-2
plugins.go
pkg/volume/plugins.go
+1
-1
No files found.
pkg/controller/garbagecollector/graph_builder.go
View file @
ebe32557
...
...
@@ -180,9 +180,8 @@ func (gb *GraphBuilder) controllerFor(resource schema.GroupVersionResource, kind
// need to clone because it's from a shared cache
shared
.
Informer
()
.
AddEventHandlerWithResyncPeriod
(
handlers
,
ResourceResyncTime
)
return
shared
.
Informer
()
.
GetController
(),
shared
.
Informer
()
.
GetStore
(),
nil
}
else
{
klog
.
V
(
4
)
.
Infof
(
"unable to use a shared informer for resource %q, kind %q: %v"
,
resource
.
String
(),
kind
.
String
(),
err
)
}
klog
.
V
(
4
)
.
Infof
(
"unable to use a shared informer for resource %q, kind %q: %v"
,
resource
.
String
(),
kind
.
String
(),
err
)
// TODO: consider store in one storage.
klog
.
V
(
5
)
.
Infof
(
"create storage for resource %s"
,
resource
)
...
...
pkg/volume/csi/csi_plugin.go
View file @
ebe32557
...
...
@@ -765,7 +765,7 @@ func (p *csiPlugin) ConstructBlockVolumeSpec(podUID types.UID, specVolName, mapP
}
// skipAttach looks up CSIDriver object associated with driver name
// to determine if driver requies attachment volume operation
// to determine if driver requi
r
es attachment volume operation
func
(
p
*
csiPlugin
)
skipAttach
(
driver
string
)
(
bool
,
error
)
{
if
!
utilfeature
.
DefaultFeatureGate
.
Enabled
(
features
.
CSIDriverRegistry
)
{
return
false
,
nil
...
...
pkg/volume/csi/csi_plugin_test.go
View file @
ebe32557
...
...
@@ -366,7 +366,7 @@ func TestPluginConstructVolumeSpec(t *testing.T) {
t
.
Fatal
(
err
)
}
if
spec
==
nil
{
t
.
Fatal
(
"nil volume.Spec con
t
structed"
)
t
.
Fatal
(
"nil volume.Spec constructed"
)
}
// inspect spec
...
...
@@ -474,7 +474,7 @@ func TestPluginConstructVolumeSpecWithInline(t *testing.T) {
t
.
Fatal
(
err
)
}
if
spec
==
nil
{
t
.
Fatal
(
"nil volume.Spec con
t
structed"
)
t
.
Fatal
(
"nil volume.Spec constructed"
)
}
if
spec
.
Name
()
!=
tc
.
specVolID
{
...
...
pkg/volume/plugins.go
View file @
ebe32557
...
...
@@ -842,7 +842,7 @@ func (pm *VolumePluginMgr) FindProvisionablePluginByName(name string) (Provision
return
nil
,
fmt
.
Errorf
(
"no provisionable volume plugin matched"
)
}
// FindDeletablePluginBySp
p
ec fetches a persistent volume plugin by spec. If
// FindDeletablePluginBySpec fetches a persistent volume plugin by spec. If
// no plugin is found, returns error.
func
(
pm
*
VolumePluginMgr
)
FindDeletablePluginBySpec
(
spec
*
Spec
)
(
DeletableVolumePlugin
,
error
)
{
volumePlugin
,
err
:=
pm
.
FindPluginBySpec
(
spec
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment