Merge pull request #49219 from jmillikin-stripe/case-insensitive-request-header-group

Automatic merge from submit-queue (batch tested with PRs 49081, 49318, 49219, 48989, 48486) Use case-insensitive header keys for `--requestheader-group-headers`. This flag is documented as being case-insensitive, but the code was doing a case-sensitive map lookup. **Release note**: ```release-note Bug fix: Parsing of `--requestheader-group-headers` in requests should be case-insensitive. ```

Merge pull request #49219 from jmillikin-stripe/case-insensitive-request-header-group
e87f809d · Kubernetes Submit Queue · GitHub · c9842a21 · 0acdc0cd · e87f809d
Commit e87f809d authored Jul 28, 2017 by Kubernetes Submit Queue Committed by GitHub Jul 28, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 16 additions and 1 deletion

requestheader.go ...pkg/authentication/request/headerrequest/requestheader.go +2 -1

requestheader_test.go ...uthentication/request/headerrequest/requestheader_test.go +14 -0

No files found.
--- a/staging/src/k8s.io/apiserver/pkg/authentication/request/headerrequest/requestheader.go
+++ b/staging/src/k8s.io/apiserver/pkg/authentication/request/headerrequest/requestheader.go
@@ -145,7 +145,8 @@ func headerValue(h http.Header, headerNames []string) string {
 func allHeaderValues(h http.Header, headerNames []string) []string {
 	ret := []string{}
 	for _, headerName := range headerNames {
-		values, ok := h[headerName]
+		headerKey := http.CanonicalHeaderKey(headerName)
+		values, ok := h[headerKey]
 		if !ok {
 			continue
 		}

--- a/staging/src/k8s.io/apiserver/pkg/authentication/request/headerrequest/requestheader_test.go
+++ b/staging/src/k8s.io/apiserver/pkg/authentication/request/headerrequest/requestheader_test.go
@@ -111,6 +111,20 @@ func TestRequestHeader(t *testing.T) {
 			},
 			expectedOk: true,
 		},
+		"groups case-insensitive": {
+			nameHeaders:  []string{"X-REMOTE-User"},
+			groupHeaders: []string{"X-REMOTE-Group"},
+			requestHeaders: http.Header{
+				"X-Remote-User":  {"Bob"},
+				"X-Remote-Group": {"Users"},
+			},
+			expectedUser: &user.DefaultInfo{
+				Name:   "Bob",
+				Groups: []string{"Users"},
+				Extra:  map[string][]string{},
+			},
+			expectedOk: true,
+		},

 		"extra prefix matches case-insensitive": {
 			nameHeaders:        []string{"X-Remote-User"},