Commit e86f43bc authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #50796 from yguo0905/hc

Automatic merge from submit-queue (batch tested with PRs 50563, 50698, 50796) Disable Docker's health check until we officially support it Ref: https://github.com/kubernetes/kubernetes/issues/50703 Tested locally. Without this PR: ``` CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES afdd796ddddc gcr.io/ygg-gke-dev/nginx-healthcheck "nginx -g 'daemon ..." 5 minutes ago Up 5 minutes (healthy) k8s_test-container_test-pod_default_8a1ad225-82bf-11e7-becb-480fcf514648_0 ``` With this PR: ``` e3fb2437555f gcr.io/ygg-gke-dev/nginx-healthcheck "nginx -g 'daemon ..." 10 seconds ago Up 9 seconds k8s_test-container_test-pod_default_de82e83c-82c0-11e7-b3fc-480fcf514648_0 ``` **Release note**: ``` Disable Docker's health check until we officially support it. ``` /assign @yujuhong /assign @dchen1107
parents 9d302ecf fe06c7ec
...@@ -131,6 +131,11 @@ func (ds *dockerService) CreateContainer(podSandboxID string, config *runtimeapi ...@@ -131,6 +131,11 @@ func (ds *dockerService) CreateContainer(podSandboxID string, config *runtimeapi
OpenStdin: config.Stdin, OpenStdin: config.Stdin,
StdinOnce: config.StdinOnce, StdinOnce: config.StdinOnce,
Tty: config.Tty, Tty: config.Tty,
// Disable Docker's health check until we officially support it
// (https://github.com/kubernetes/kubernetes/issues/25829).
Healthcheck: &dockercontainer.HealthConfig{
Test: []string{"NONE"},
},
}, },
HostConfig: &dockercontainer.HostConfig{ HostConfig: &dockercontainer.HostConfig{
Binds: generateMountBindings(config.GetMounts()), Binds: generateMountBindings(config.GetMounts()),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment