Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
e67d5f2d
Commit
e67d5f2d
authored
Feb 07, 2019
by
Dr. Stefan Schimanski
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
apiserver: fix openapi extension types to be JSON
parent
01bc4eff
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
25 additions
and
15 deletions
+25
-15
BUILD
staging/src/k8s.io/apiserver/pkg/endpoints/openapi/BUILD
+0
-1
openapi.go
...ing/src/k8s.io/apiserver/pkg/endpoints/openapi/openapi.go
+13
-1
openapi_test.go
...rc/k8s.io/apiserver/pkg/endpoints/openapi/openapi_test.go
+6
-7
genericapiserver_test.go
.../src/k8s.io/apiserver/pkg/server/genericapiserver_test.go
+4
-4
proto_test.go
staging/src/k8s.io/apiserver/pkg/util/openapi/proto_test.go
+2
-2
No files found.
staging/src/k8s.io/apiserver/pkg/endpoints/openapi/BUILD
View file @
e67d5f2d
...
@@ -11,7 +11,6 @@ go_test(
...
@@ -11,7 +11,6 @@ go_test(
srcs = ["openapi_test.go"],
srcs = ["openapi_test.go"],
embed = [":go_default_library"],
embed = [":go_default_library"],
deps = [
deps = [
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
"//staging/src/k8s.io/apiserver/pkg/endpoints/openapi/testing:go_default_library",
"//staging/src/k8s.io/apiserver/pkg/endpoints/openapi/testing:go_default_library",
"//vendor/github.com/go-openapi/spec:go_default_library",
"//vendor/github.com/go-openapi/spec:go_default_library",
...
...
staging/src/k8s.io/apiserver/pkg/endpoints/openapi/openapi.go
View file @
e67d5f2d
...
@@ -108,6 +108,18 @@ func (s groupVersionKinds) Less(i, j int) bool {
...
@@ -108,6 +108,18 @@ func (s groupVersionKinds) Less(i, j int) bool {
return
s
[
i
]
.
Group
<
s
[
j
]
.
Group
return
s
[
i
]
.
Group
<
s
[
j
]
.
Group
}
}
func
(
s
groupVersionKinds
)
JSON
()
[]
interface
{}
{
j
:=
[]
interface
{}{}
for
_
,
gvk
:=
range
s
{
j
=
append
(
j
,
map
[
string
]
interface
{}{
"group"
:
gvk
.
Group
,
"version"
:
gvk
.
Version
,
"kind"
:
gvk
.
Kind
,
})
}
return
j
}
// DefinitionNamer is the type to customize OpenAPI definition name.
// DefinitionNamer is the type to customize OpenAPI definition name.
type
DefinitionNamer
struct
{
type
DefinitionNamer
struct
{
typeGroupVersionKinds
map
[
string
]
groupVersionKinds
typeGroupVersionKinds
map
[
string
]
groupVersionKinds
...
@@ -172,7 +184,7 @@ func NewDefinitionNamer(schemes ...*runtime.Scheme) *DefinitionNamer {
...
@@ -172,7 +184,7 @@ func NewDefinitionNamer(schemes ...*runtime.Scheme) *DefinitionNamer {
func
(
d
*
DefinitionNamer
)
GetDefinitionName
(
name
string
)
(
string
,
spec
.
Extensions
)
{
func
(
d
*
DefinitionNamer
)
GetDefinitionName
(
name
string
)
(
string
,
spec
.
Extensions
)
{
if
groupVersionKinds
,
ok
:=
d
.
typeGroupVersionKinds
[
name
];
ok
{
if
groupVersionKinds
,
ok
:=
d
.
typeGroupVersionKinds
[
name
];
ok
{
return
friendlyName
(
name
),
spec
.
Extensions
{
return
friendlyName
(
name
),
spec
.
Extensions
{
extensionGVK
:
[]
v1
.
GroupVersionKind
(
groupVersionKinds
),
extensionGVK
:
groupVersionKinds
.
JSON
(
),
}
}
}
}
return
friendlyName
(
name
),
nil
return
friendlyName
(
name
),
nil
...
...
staging/src/k8s.io/apiserver/pkg/endpoints/openapi/openapi_test.go
View file @
e67d5f2d
...
@@ -23,7 +23,6 @@ import (
...
@@ -23,7 +23,6 @@ import (
"github.com/go-openapi/spec"
"github.com/go-openapi/spec"
"k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime"
openapitesting
"k8s.io/apiserver/pkg/endpoints/openapi/testing"
openapitesting
"k8s.io/apiserver/pkg/endpoints/openapi/testing"
)
)
...
@@ -58,13 +57,13 @@ func TestGetDefinitionName(t *testing.T) {
...
@@ -58,13 +57,13 @@ func TestGetDefinitionName(t *testing.T) {
namer
:=
NewDefinitionNamer
(
s
)
namer
:=
NewDefinitionNamer
(
s
)
n
,
e
:=
namer
.
GetDefinitionName
(
typePkgName
)
n
,
e
:=
namer
.
GetDefinitionName
(
typePkgName
)
assertEqual
(
t
,
typeFriendlyName
,
n
)
assertEqual
(
t
,
typeFriendlyName
,
n
)
assertEqual
(
t
,
e
[
"x-kubernetes-group-version-kind"
],
[]
v1
.
GroupVersionKind
{
assertEqual
(
t
,
[]
interface
{}
{
{
map
[
string
]
interface
{}
{
Group
:
"test"
,
"group"
:
"test"
,
Version
:
"v1"
,
"version"
:
"v1"
,
Kind
:
"TestType"
,
"kind"
:
"TestType"
,
},
},
})
}
,
e
[
"x-kubernetes-group-version-kind"
]
)
n
,
e2
:=
namer
.
GetDefinitionName
(
"test.com/another.Type"
)
n
,
e2
:=
namer
.
GetDefinitionName
(
"test.com/another.Type"
)
assertEqual
(
t
,
"com.test.another.Type"
,
n
)
assertEqual
(
t
,
"com.test.another.Type"
,
n
)
assertEqual
(
t
,
e2
,
spec
.
Extensions
(
nil
))
assertEqual
(
t
,
e2
,
spec
.
Extensions
(
nil
))
...
...
staging/src/k8s.io/apiserver/pkg/server/genericapiserver_test.go
View file @
e67d5f2d
...
@@ -89,18 +89,18 @@ func buildTestOpenAPIDefinition() kubeopenapi.OpenAPIDefinition {
...
@@ -89,18 +89,18 @@ func buildTestOpenAPIDefinition() kubeopenapi.OpenAPIDefinition {
},
},
VendorExtensible
:
openapi
.
VendorExtensible
{
VendorExtensible
:
openapi
.
VendorExtensible
{
Extensions
:
openapi
.
Extensions
{
Extensions
:
openapi
.
Extensions
{
"x-kubernetes-group-version-kind"
:
[]
map
[
string
]
string
{
"x-kubernetes-group-version-kind"
:
[]
interface
{}
{
{
map
[
string
]
interface
{}
{
"group"
:
""
,
"group"
:
""
,
"version"
:
"v1"
,
"version"
:
"v1"
,
"kind"
:
"Getter"
,
"kind"
:
"Getter"
,
},
},
{
map
[
string
]
interface
{}
{
"group"
:
"batch"
,
"group"
:
"batch"
,
"version"
:
"v1"
,
"version"
:
"v1"
,
"kind"
:
"Getter"
,
"kind"
:
"Getter"
,
},
},
{
map
[
string
]
interface
{}
{
"group"
:
"extensions"
,
"group"
:
"extensions"
,
"version"
:
"v1"
,
"version"
:
"v1"
,
"kind"
:
"Getter"
,
"kind"
:
"Getter"
,
...
...
staging/src/k8s.io/apiserver/pkg/util/openapi/proto_test.go
View file @
e67d5f2d
...
@@ -44,8 +44,8 @@ func TestOpenAPIDefinitionsToProtoModels(t *testing.T) {
...
@@ -44,8 +44,8 @@ func TestOpenAPIDefinitionsToProtoModels(t *testing.T) {
},
},
VendorExtensible
:
spec
.
VendorExtensible
{
VendorExtensible
:
spec
.
VendorExtensible
{
Extensions
:
spec
.
Extensions
{
Extensions
:
spec
.
Extensions
{
"x-kubernetes-group-version-kind"
:
[]
map
[
string
]
string
{
"x-kubernetes-group-version-kind"
:
[]
interface
{}
{
{
map
[
string
]
interface
{}
{
"group"
:
"testgroup.k8s.io"
,
"group"
:
"testgroup.k8s.io"
,
"version"
:
"v1"
,
"version"
:
"v1"
,
"kind"
:
"Foo"
,
"kind"
:
"Foo"
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment