Commit e3eac372 authored by Zihong Zheng's avatar Zihong Zheng

service_controller: Include service key in error messages

parent 7d4f21d0
...@@ -759,7 +759,7 @@ func (s *ServiceController) syncService(key string) error { ...@@ -759,7 +759,7 @@ func (s *ServiceController) syncService(key string) error {
if retryDelay != 0 { if retryDelay != 0 {
// Add the failed service back to the queue so we'll retry it. // Add the failed service back to the queue so we'll retry it.
glog.Errorf("Failed to process service. Retrying in %s: %v", retryDelay, err) glog.Errorf("Failed to process service %v. Retrying in %s: %v", key, retryDelay, err)
go func(obj interface{}, delay time.Duration) { go func(obj interface{}, delay time.Duration) {
// put back the service key to working queue, it is possible that more entries of the service // put back the service key to working queue, it is possible that more entries of the service
// were added into the queue during the delay, but it does not mess as when handling the retry, // were added into the queue during the delay, but it does not mess as when handling the retry,
...@@ -767,7 +767,7 @@ func (s *ServiceController) syncService(key string) error { ...@@ -767,7 +767,7 @@ func (s *ServiceController) syncService(key string) error {
s.workingQueue.AddAfter(obj, delay) s.workingQueue.AddAfter(obj, delay)
}(key, retryDelay) }(key, retryDelay)
} else if err != nil { } else if err != nil {
runtime.HandleError(fmt.Errorf("Failed to process service. Not retrying: %v", err)) runtime.HandleError(fmt.Errorf("Failed to process service %v. Not retrying: %v", key, err))
} }
return nil return nil
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment