Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
e31d14cb
Commit
e31d14cb
authored
Oct 12, 2018
by
Antoine Pelisse
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
kubectl diff: Rename KUBERNETES_EXTERNAL_DIFF to KUBECTL_EXTERNAL_DIFF
parent
6fc89ae9
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
5 deletions
+4
-5
diff.go
pkg/kubectl/cmd/diff/diff.go
+3
-4
diff_test.go
pkg/kubectl/cmd/diff/diff_test.go
+1
-1
No files found.
pkg/kubectl/cmd/diff/diff.go
View file @
e31d14cb
...
@@ -26,7 +26,6 @@ import (
...
@@ -26,7 +26,6 @@ import (
"github.com/ghodss/yaml"
"github.com/ghodss/yaml"
"github.com/jonboulle/clockwork"
"github.com/jonboulle/clockwork"
"github.com/spf13/cobra"
"github.com/spf13/cobra"
"k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/errors"
metav1
"k8s.io/apimachinery/pkg/apis/meta/v1"
metav1
"k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
...
@@ -50,7 +49,7 @@ var (
...
@@ -50,7 +49,7 @@ var (
Output is always YAML.
Output is always YAML.
KUBE
RNETES
_EXTERNAL_DIFF environment variable can be used to select your own
KUBE
CTL
_EXTERNAL_DIFF environment variable can be used to select your own
diff command. By default, the "diff" command available in your path will be
diff command. By default, the "diff" command available in your path will be
run with "-u" (unicode) and "-N" (treat new files as empty) options.`
))
run with "-u" (unicode) and "-N" (treat new files as empty) options.`
))
diffExample
=
templates
.
Examples
(
i18n
.
T
(
`
diffExample
=
templates
.
Examples
(
i18n
.
T
(
`
...
@@ -98,7 +97,7 @@ func NewCmdDiff(f cmdutil.Factory, streams genericclioptions.IOStreams) *cobra.C
...
@@ -98,7 +97,7 @@ func NewCmdDiff(f cmdutil.Factory, streams genericclioptions.IOStreams) *cobra.C
}
}
// DiffProgram finds and run the diff program. The value of
// DiffProgram finds and run the diff program. The value of
// KUBE
RNETES
_EXTERNAL_DIFF environment variable will be used a diff
// KUBE
CTL
_EXTERNAL_DIFF environment variable will be used a diff
// program. By default, `diff(1)` will be used.
// program. By default, `diff(1)` will be used.
type
DiffProgram
struct
{
type
DiffProgram
struct
{
Exec
exec
.
Interface
Exec
exec
.
Interface
...
@@ -107,7 +106,7 @@ type DiffProgram struct {
...
@@ -107,7 +106,7 @@ type DiffProgram struct {
func
(
d
*
DiffProgram
)
getCommand
(
args
...
string
)
exec
.
Cmd
{
func
(
d
*
DiffProgram
)
getCommand
(
args
...
string
)
exec
.
Cmd
{
diff
:=
""
diff
:=
""
if
envDiff
:=
os
.
Getenv
(
"KUBE
RNETES
_EXTERNAL_DIFF"
);
envDiff
!=
""
{
if
envDiff
:=
os
.
Getenv
(
"KUBE
CTL
_EXTERNAL_DIFF"
);
envDiff
!=
""
{
diff
=
envDiff
diff
=
envDiff
}
else
{
}
else
{
diff
=
"diff"
diff
=
"diff"
...
...
pkg/kubectl/cmd/diff/diff_test.go
View file @
e31d14cb
...
@@ -52,7 +52,7 @@ func (f *FakeObject) Live() runtime.Object {
...
@@ -52,7 +52,7 @@ func (f *FakeObject) Live() runtime.Object {
}
}
func
TestDiffProgram
(
t
*
testing
.
T
)
{
func
TestDiffProgram
(
t
*
testing
.
T
)
{
os
.
Setenv
(
"KUBE
RNETES
_EXTERNAL_DIFF"
,
"echo"
)
os
.
Setenv
(
"KUBE
CTL
_EXTERNAL_DIFF"
,
"echo"
)
streams
,
_
,
stdout
,
_
:=
genericclioptions
.
NewTestIOStreams
()
streams
,
_
,
stdout
,
_
:=
genericclioptions
.
NewTestIOStreams
()
diff
:=
DiffProgram
{
diff
:=
DiffProgram
{
IOStreams
:
streams
,
IOStreams
:
streams
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment