Merge pull request #56554 from m1093782566/win-test

Automatic merge from submit-queue (batch tested with PRs 56894, 56940, 55223, 56554, 54985). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove dead code in winkernel proxy UT **What this PR does / why we need it**: There is a `+build windows` tag in `pkg/proxy/winkernel/proxier_test.go`, it means the UTs will not run in upstream CI. Plus, the UT codes in `pkg/proxy/winkernel/proxier_test.go` are not for winkernel proxier, instead they are for iptables proxier! We should remove the dead code in winkernel proxy UT and then create the winkernel-specific UTs. **Which issue(s) this PR fixes**: Fixes #56555 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```

Merge pull request #56554 from m1093782566/win-test
e113c750 · Kubernetes Submit Queue · GitHub · 2ed40242 · b5aab25f · e113c750
Unverified Commit e113c750 authored Dec 16, 2017 by Kubernetes Submit Queue Committed by GitHub Dec 16, 2017
Expand all Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 28 deletions

BUILD pkg/proxy/winkernel/BUILD +1 -28

proxier_test.go pkg/proxy/winkernel/proxier_test.go +0 -0

No files found.
--- a/pkg/proxy/winkernel/BUILD
+++ b/pkg/proxy/winkernel/BUILD
-load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")

 go_library(
    name = "go_default_library",
@@ -36,33 +36,6 @@ go_library(
    }),
 )

-go_test(
-    name = "go_default_test",
-    srcs = select({
-        "@io_bazel_rules_go//go/platform:windows_amd64": [
-            "proxier_test.go",
-        ],
-        "//conditions:default": [],
-    }),
-    importpath = "k8s.io/kubernetes/pkg/proxy/winkernel",
-    library = ":go_default_library",
-    deps = select({
-        "@io_bazel_rules_go//go/platform:windows_amd64": [
-            "//pkg/apis/core:go_default_library",
-            "//pkg/proxy:go_default_library",
-            "//pkg/util/async:go_default_library",
-            "//vendor/github.com/davecgh/go-spew/spew:go_default_library",
-            "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
-            "//vendor/k8s.io/apimachinery/pkg/types:go_default_library",
-            "//vendor/k8s.io/apimachinery/pkg/util/intstr:go_default_library",
-            "//vendor/k8s.io/apimachinery/pkg/util/sets:go_default_library",
-            "//vendor/k8s.io/utils/exec:go_default_library",
-            "//vendor/k8s.io/utils/exec/testing:go_default_library",
-        ],
-        "//conditions:default": [],
-    }),
-)
-
 filegroup(
    name = "package-srcs",
    srcs = glob(["**"]),

--- a/pkg/proxy/winkernel/proxier_test.go
+++ b/pkg/proxy/winkernel/proxier_test.go