Skip to content

K
k3s
Commit de41fd39 authored by Huamin Chen's avatar Huamin Chen
Browse files
Options

rbd: no more remount.

remount was originally needed to ensure rw/ro is set correctly. There is no such need since mount is using exec interface Signed-off-by: 's avatarHuamin Chen <hchen@redhat.com>
parent 418a8b50
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 11 deletions
pkg/volume/rbd/rbd.go
View file @ de41fd39
...@@ -201,18 +201,8 @@ func (b *rbdBuilder) SetUpAt(dir string) error { ...@@ -201,18 +201,8 @@ func (b *rbdBuilder) SetUpAt(dir string) error {
err := diskSetUp(b.manager, *b, dir, b.mounter) err := diskSetUp(b.manager, *b, dir, b.mounter)
if err != nil { if err != nil {
glog.Errorf("rbd: failed to setup") glog.Errorf("rbd: failed to setup")
return err
} }
globalPDPath := b.manager.MakeGlobalPDName(*b.rbd) return err
// make mountpoint rw/ro work as expected
//FIXME revisit pkg/util/mount and ensure rw/ro is implemented as expected
mode := "rw"
if b.ReadOnly {
mode = "ro"
}
b.plugin.execCommand("mount", []string{"-o", "remount," + mode, globalPDPath, dir})
return nil
} }
type rbdCleaner struct { type rbdCleaner struct {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment