Skip to content

K
k3s
Unverified Commit de1a0e32 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #60925 from aleksandra-malinowska/debug-curl-fix

Automatic merge from submit-queue (batch tested with PRs 60696, 60876, 60901, 60925, 60428). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Improve debug curl command When logging debug curl command, add single quotes around URL and headers. This prevents quietly removing any parameters after '&' when running resulting command and improves formatting. ```release-note NONE ```
parents 7543ddde 42f756ae
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
staging/src/k8s.io/client-go/transport/round_trippers.go
View file @ de1a0e32
...@@ -331,11 +331,11 @@ func (r *requestInfo) toCurl() string { ...@@ -331,11 +331,11 @@ func (r *requestInfo) toCurl() string {
headers := "" headers := ""
for key, values := range r.RequestHeaders { for key, values := range r.RequestHeaders {
for _, value := range values { for _, value := range values {
headers += fmt.Sprintf(` -H %q`, fmt.Sprintf("%s: %s", key, value)) headers += fmt.Sprintf(` -H %q`, fmt.Sprintf("%s: '%s'", key, value))
} }
} }
return fmt.Sprintf("curl -k -v -X%s %s %s", r.RequestVerb, headers, r.RequestURL) return fmt.Sprintf("curl -k -v -X%s %s '%s'", r.RequestVerb, headers, r.RequestURL)
} }
// debuggingRoundTripper will display information about the requests passing // debuggingRoundTripper will display information about the requests passing
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment