Skip to content

K
k3s
Commit dd351db7 authored by Justin Santa Barbara's avatar Justin Santa Barbara
Browse files
Options

conversion-gen: add --skip-unsafe flag

We should expose the SkipUnsafe option, for legacy compatability, so that conversion-go can be used in other projects, and for platforms where unsafe is not available. Make unsafe code generation the default though, and have the help text hint that the resulting code is sub-optimal.
parent 702c33a5
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 0 deletions
cmd/libs/go2idl/conversion-gen/main.go
View file @ dd351db7
...@@ -64,6 +64,8 @@ func main() { ...@@ -64,6 +64,8 @@ func main() {
} }
pflag.CommandLine.StringSliceVar(&customArgs.ExtraPeerDirs, "extra-peer-dirs", customArgs.ExtraPeerDirs, pflag.CommandLine.StringSliceVar(&customArgs.ExtraPeerDirs, "extra-peer-dirs", customArgs.ExtraPeerDirs,
"Comma-separated list of import paths which are considered, after tag-specified peers, for conversions.") "Comma-separated list of import paths which are considered, after tag-specified peers, for conversions.")
pflag.CommandLine.BoolVar(&customArgs.SkipUnsafe, "skip-unsafe", customArgs.SkipUnsafe,
"If true, will not generate code using unsafe pointer conversions; resulting code may be slower.")
arguments.CustomArgs = customArgs arguments.CustomArgs = customArgs
// Run it. // Run it.
......
hack/verify-flags/known-flags.txt
View file @ dd351db7
...@@ -561,6 +561,7 @@ since-time ...@@ -561,6 +561,7 @@ since-time
skip-generated-rewrite skip-generated-rewrite
skip-munges skip-munges
skip-preflight-checks skip-preflight-checks
skip-unsafe
sort-by sort-by
source-file source-file
ssh-env ssh-env
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment