Merge pull request #47539 from gnufied/deprecate-keep-terminated-pod-volumes

Automatic merge from submit-queue (batch tested with PRs 45813, 49594, 49443, 49167, 47539) Deprecate keep-terminated-pod-volumes It was discussed and agreed by sig-storage that this flag causes unnecessary confusion and is hard to keep synchornized with controller's attach/detach functionality. Fixes https://github.com/kubernetes/kubernetes/issues/45615 ```release-note keep-terminated-pod-volumes flag on kubelet is deprecated. ```

Merge pull request #47539 from gnufied/deprecate-keep-terminated-pod-volumes
dcb1d287 · Kubernetes Submit Queue · GitHub · ceedc781 · 4c37faaa · dcb1d287
Commit dcb1d287 authored Jul 28, 2017 by Kubernetes Submit Queue Committed by GitHub Jul 28, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

options.go cmd/kubelet/app/options/options.go +1 -0

No files found.
--- a/cmd/kubelet/app/options/options.go
+++ b/cmd/kubelet/app/options/options.go
@@ -278,6 +278,7 @@ func (c *kubeletConfiguration) addFlags(fs *pflag.FlagSet) {
 	fs.Int32Var(&c.PodsPerCore, "pods-per-core", c.PodsPerCore, "Number of Pods per core that can run on this Kubelet. The total number of Pods on this Kubelet cannot exceed max-pods, so max-pods will be used if this calculation results in a larger number of Pods allowed on the Kubelet. A value of 0 disables this limit.")
 	fs.BoolVar(&c.ProtectKernelDefaults, "protect-kernel-defaults", c.ProtectKernelDefaults, "Default kubelet behaviour for kernel tuning. If set, kubelet errors if any of kernel tunables is different than kubelet defaults.")
 	fs.BoolVar(&c.KeepTerminatedPodVolumes, "keep-terminated-pod-volumes", c.KeepTerminatedPodVolumes, "Keep terminated pod volumes mounted to the node after the pod terminates.  Can be useful for debugging volume related issues.")
+	fs.MarkDeprecated("keep-terminated-pod-volumes", "will be removed in a future version")

 	// CRI flags.
 	fs.StringVar(&c.RemoteRuntimeEndpoint, "container-runtime-endpoint", c.RemoteRuntimeEndpoint, "[Experimental] The endpoint of remote runtime service. Currently unix socket is supported on Linux, and tcp is supported on windows.  Examples:'unix:///var/run/dockershim.sock', 'tcp://localhost:3735'")