Commit dc3674c8 authored by Piotr Skamruk's avatar Piotr Skamruk

Ensure that we are closing files.

parent ff1cec99
...@@ -612,6 +612,7 @@ func (s *SchedulerServer) Run(hks hyperkube.Interface, _ []string) error { ...@@ -612,6 +612,7 @@ func (s *SchedulerServer) Run(hks hyperkube.Interface, _ []string) error {
if err != nil { if err != nil {
log.Fatalf("Cannot open scheduler config file: %v", err) log.Fatalf("Cannot open scheduler config file: %v", err)
} }
defer f.Close()
err = sc.Read(bufio.NewReader(f)) err = sc.Read(bufio.NewReader(f))
if err != nil { if err != nil {
......
...@@ -156,6 +156,7 @@ func readInstanceID() (string, error) { ...@@ -156,6 +156,7 @@ func readInstanceID() (string, error) {
if err != nil { if err != nil {
return "", fmt.Errorf("Cannot open %s: %v", metaDataPath, err) return "", fmt.Errorf("Cannot open %s: %v", metaDataPath, err)
} }
defer file.Close()
return parseMetaData(file) return parseMetaData(file)
} }
......
...@@ -66,6 +66,7 @@ func readBytesFromFile(t *testing.T, filename string) []byte { ...@@ -66,6 +66,7 @@ func readBytesFromFile(t *testing.T, filename string) []byte {
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
defer file.Close()
data, err := ioutil.ReadAll(file) data, err := ioutil.ReadAll(file)
if err != nil { if err != nil {
......
...@@ -242,6 +242,7 @@ current-context: default ...@@ -242,6 +242,7 @@ current-context: default
if err != nil { if err != nil {
return fmt.Errorf("failed to read test config: %v", err) return fmt.Errorf("failed to read test config: %v", err)
} }
defer configFile.Close()
_, err = NewImagePolicyWebhook(fake.NewSimpleClientset(), configFile) _, err = NewImagePolicyWebhook(fake.NewSimpleClientset(), configFile)
return err return err
...@@ -402,6 +403,7 @@ func newImagePolicyWebhook(callbackURL string, clientCert, clientKey, ca []byte, ...@@ -402,6 +403,7 @@ func newImagePolicyWebhook(callbackURL string, clientCert, clientKey, ca []byte,
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to read test config: %v", err) return nil, fmt.Errorf("failed to read test config: %v", err)
} }
defer configFile.Close()
wh, err := NewImagePolicyWebhook(fake.NewSimpleClientset(), configFile) wh, err := NewImagePolicyWebhook(fake.NewSimpleClientset(), configFile)
return wh.(*imagePolicyWebhook), err return wh.(*imagePolicyWebhook), err
} }
......
...@@ -1528,6 +1528,7 @@ func readBytesFromFile(filename string) []byte { ...@@ -1528,6 +1528,7 @@ func readBytesFromFile(filename string) []byte {
framework.Failf(err.Error()) framework.Failf(err.Error())
} }
defer file.Close() defer file.Close()
data, err := ioutil.ReadAll(file) data, err := ioutil.ReadAll(file)
if err != nil { if err != nil {
framework.Failf(err.Error()) framework.Failf(err.Error())
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment