Unverified Commit dc1d86e6 authored by Brian Downs's avatar Brian Downs Committed by GitHub

Merge pull request #3177 from briandowns/backport_pr_3155

[Backport 1.19] Hidden Flags Bug Fix
parents f9450c84 a3dcc9de
// +build no_etcd
package cmds
const (
hideClusterFlags = true
)
...@@ -12,7 +12,6 @@ const ( ...@@ -12,7 +12,6 @@ const (
defaultSnapshotRentention = 5 defaultSnapshotRentention = 5
defaultSnapshotIntervalHours = 12 defaultSnapshotIntervalHours = 12
hideClusterFlags = true
) )
type Server struct { type Server struct {
...@@ -333,19 +332,19 @@ func NewServerCommand(action func(*cli.Context) error) cli.Command { ...@@ -333,19 +332,19 @@ func NewServerCommand(action func(*cli.Context) error) cli.Command {
}, },
cli.BoolFlag{ cli.BoolFlag{
Name: "disable-api-server", Name: "disable-api-server",
Hidden: hideClusterFlags, Hidden: true,
Usage: "(experimental/components) Disable running api server", Usage: "(experimental/components) Disable running api server",
Destination: &ServerConfig.DisableAPIServer, Destination: &ServerConfig.DisableAPIServer,
}, },
cli.BoolFlag{ cli.BoolFlag{
Name: "disable-controller-manager", Name: "disable-controller-manager",
Hidden: hideClusterFlags, Hidden: true,
Usage: "(experimental/components) Disable running kube-controller-manager", Usage: "(experimental/components) Disable running kube-controller-manager",
Destination: &ServerConfig.DisableControllerManager, Destination: &ServerConfig.DisableControllerManager,
}, },
cli.BoolFlag{ cli.BoolFlag{
Name: "disable-etcd", Name: "disable-etcd",
Hidden: hideClusterFlags, Hidden: true,
Usage: "(experimental/components) Disable running etcd", Usage: "(experimental/components) Disable running etcd",
Destination: &ServerConfig.DisableETCD, Destination: &ServerConfig.DisableETCD,
}, },
...@@ -385,21 +384,18 @@ func NewServerCommand(action func(*cli.Context) error) cli.Command { ...@@ -385,21 +384,18 @@ func NewServerCommand(action func(*cli.Context) error) cli.Command {
}, },
cli.StringFlag{ cli.StringFlag{
Name: "server,s", Name: "server,s",
Hidden: hideClusterFlags,
Usage: "(experimental/cluster) Server to connect to, used to join a cluster", Usage: "(experimental/cluster) Server to connect to, used to join a cluster",
EnvVar: version.ProgramUpper + "_URL", EnvVar: version.ProgramUpper + "_URL",
Destination: &ServerConfig.ServerURL, Destination: &ServerConfig.ServerURL,
}, },
cli.BoolFlag{ cli.BoolFlag{
Name: "cluster-init", Name: "cluster-init",
Hidden: hideClusterFlags, Usage: "(experimental/cluster) Initialize a new cluster using embedded Etcd",
Usage: "(experimental/cluster) Initialize a new cluster",
EnvVar: version.ProgramUpper + "_CLUSTER_INIT", EnvVar: version.ProgramUpper + "_CLUSTER_INIT",
Destination: &ServerConfig.ClusterInit, Destination: &ServerConfig.ClusterInit,
}, },
cli.BoolFlag{ cli.BoolFlag{
Name: "cluster-reset", Name: "cluster-reset",
Hidden: hideClusterFlags,
Usage: "(experimental/cluster) Forget all peers and become sole member of a new cluster", Usage: "(experimental/cluster) Forget all peers and become sole member of a new cluster",
EnvVar: version.ProgramUpper + "_CLUSTER_RESET", EnvVar: version.ProgramUpper + "_CLUSTER_RESET",
Destination: &ServerConfig.ClusterReset, Destination: &ServerConfig.ClusterReset,
......
// +build !no_etcd
package cluster package cluster
import ( import (
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment