Unverified Commit da9a4d5d authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #57286 from vmware/controller-mgr-fix

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fixing vSphere Cloud Provider to use "vsphere-cloud-provider" to create ClientBuilder **What this PR does / why we need it**: vSphere cloud Provider is not using lower case naming while creating clientBuilder. With this fix, ClientBuilder is created using lowercase naming. With mixed upper-lower case name, controller manager is crashing. **Which issue(s) this PR fixes** Fixes # https://github.com/kubernetes/kubernetes/issues/57279 **Special notes for your reviewer**: None **Release note**: ```release-note This fixes controller manager crash in certain vSphere cloud provider environment. ```
parents 5bd0d98d a043d451
...@@ -217,7 +217,7 @@ func (vs *VSphere) Initialize(clientBuilder controller.ControllerClientBuilder) ...@@ -217,7 +217,7 @@ func (vs *VSphere) Initialize(clientBuilder controller.ControllerClientBuilder)
// Only on controller node it is required to register listeners. // Only on controller node it is required to register listeners.
// Register callbacks for node updates // Register callbacks for node updates
client := clientBuilder.ClientOrDie("vSphere-cloud-provider") client := clientBuilder.ClientOrDie("vsphere-cloud-provider")
factory := informers.NewSharedInformerFactory(client, 5*time.Minute) factory := informers.NewSharedInformerFactory(client, 5*time.Minute)
nodeInformer := factory.Core().V1().Nodes() nodeInformer := factory.Core().V1().Nodes()
nodeInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{ nodeInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment