Merge pull request #67809 from Pingan2017/dafaultfitler

Automatic merge from submit-queue (batch tested with PRs 67362, 67256, 67809). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. del unused func DefaultEventFilterFunc **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```

Merge pull request #67809 from Pingan2017/dafaultfitler
da62c170 · Kubernetes Submit Queue · GitHub · 7b96c818 · 655271f8 · da62c170
Unverified Commit da62c170 authored Aug 27, 2018 by Kubernetes Submit Queue Committed by GitHub Aug 27, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 13 deletions

events_cache.go staging/src/k8s.io/client-go/tools/record/events_cache.go +0 -5

events_cache_test.go ...ng/src/k8s.io/client-go/tools/record/events_cache_test.go +0 -8

No files found.
--- a/staging/src/k8s.io/client-go/tools/record/events_cache.go
+++ b/staging/src/k8s.io/client-go/tools/record/events_cache.go
@@ -84,11 +84,6 @@ func getSpamKey(event *v1.Event) string {
 // EventFilterFunc is a function that returns true if the event should be skipped
 type EventFilterFunc func(event *v1.Event) bool

-// DefaultEventFilterFunc returns false for all incoming events
-func DefaultEventFilterFunc(event *v1.Event) bool {
-	return false
-}
-
 // EventSourceObjectSpamFilter is responsible for throttling
 // the amount of events a source and object can produce.
 type EventSourceObjectSpamFilter struct {

--- a/staging/src/k8s.io/client-go/tools/record/events_cache_test.go
+++ b/staging/src/k8s.io/client-go/tools/record/events_cache_test.go
@@ -127,14 +127,6 @@ func validateEvent(messagePrefix string, actualEvent *v1.Event, expectedEvent *v
 	return actualEvent, nil
 }

-// TestDefaultEventFilterFunc ensures that no events are filtered
-func TestDefaultEventFilterFunc(t *testing.T) {
-	event := makeEvent("end-of-world", "it was fun", makeObjectReference("Pod", "pod1", "other"))
-	if DefaultEventFilterFunc(&event) {
-		t.Fatalf("DefaultEventFilterFunc should always return false")
-	}
-}
-
 // TestEventAggregatorByReasonFunc ensures that two events are aggregated if they vary only by event.message
 func TestEventAggregatorByReasonFunc(t *testing.T) {
 	event1 := makeEvent("end-of-world", "it was fun", makeObjectReference("Pod", "pod1", "other"))