Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
d9dabd74
Commit
d9dabd74
authored
Jun 19, 2015
by
Piotr Szczesniak
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #10086 from marekbiskup/issues-for-TODO
add issue reference to TODOs
parents
31675c2b
ade1399e
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
3 deletions
+7
-3
resize_nodes.go
test/e2e/resize_nodes.go
+7
-3
No files found.
test/e2e/resize_nodes.go
View file @
d9dabd74
...
...
@@ -278,10 +278,12 @@ func performTemporaryNetworkFailure(c *client.Client, ns, rcName string, replica
}
By
(
fmt
.
Sprintf
(
"block network traffic from node %s to the master"
,
node
.
Name
))
// TODO: The use of MasterName will cause iptables to do a DNS lookup to
// TODO marekbiskup 2015-06-19 #10085
// The use of MasterName will cause iptables to do a DNS lookup to
// resolve the name to an IP address, which will slow down the test
// and cause it to fail if DNS is absent or broken.
// Use the IP address instead.
iptablesRule
:=
fmt
.
Sprintf
(
"OUTPUT --destination %s --jump DROP"
,
testContext
.
CloudConfig
.
MasterName
)
defer
func
()
{
// This code will execute even if setting the iptables rule failed.
...
...
@@ -456,11 +458,13 @@ var _ = Describe("Nodes", func() {
}
})
// TODO: this test has nothing to do with resizing nodes so it should be moved elsewhere.
// TODO: two things are tested here:
// TODO marekbiskup 2015-06-19 #10085
// This test has nothing to do with resizing nodes so it should be moved elsewhere.
// Two things are tested here:
// 1. pods from a uncontactable nodes are rescheduled
// 2. when a node joins the cluster, it can host new pods.
// Factor out the cases into two separate tests.
testName
=
"Uncontactable nodes, have their pods recreated by a replication controller, and can host new pods after rejoining."
It
(
testName
,
func
()
{
if
testContext
.
CloudConfig
.
NumNodes
<
2
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment