Unverified Commit d8b9d9b3 authored by k8s-ci-robot's avatar k8s-ci-robot Committed by GitHub

Merge pull request #71370 from WanLinghao/serialization_test_fix

fix unit test failure in ./pkg/api/testing/serialization_test.go
parents a93fe6e9 82f8f3e7
...@@ -86,9 +86,11 @@ func TestSetControllerConversion(t *testing.T) { ...@@ -86,9 +86,11 @@ func TestSetControllerConversion(t *testing.T) {
rs := &apps.ReplicaSet{} rs := &apps.ReplicaSet{}
rc := &api.ReplicationController{} rc := &api.ReplicationController{}
extGroup := schema.GroupVersion{Group: "apps", Version: "v1"}
extCodec := legacyscheme.Codecs.LegacyCodec(extGroup)
extGroup := testapi.Apps defaultGroup := schema.GroupVersion{Group: "", Version: "v1"}
defaultGroup := testapi.Default defaultCodec := legacyscheme.Codecs.LegacyCodec(defaultGroup)
fuzzInternalObject(t, schema.GroupVersion{Group: "apps", Version: runtime.APIVersionInternal}, rs, rand.Int63()) fuzzInternalObject(t, schema.GroupVersion{Group: "apps", Version: runtime.APIVersionInternal}, rs, rand.Int63())
...@@ -102,7 +104,7 @@ func TestSetControllerConversion(t *testing.T) { ...@@ -102,7 +104,7 @@ func TestSetControllerConversion(t *testing.T) {
} }
t.Logf("rs._internal.apps -> rs.v1.apps") t.Logf("rs._internal.apps -> rs.v1.apps")
data, err := runtime.Encode(extGroup.Codec(), rs) data, err := runtime.Encode(extCodec, rs)
if err != nil { if err != nil {
t.Fatalf("unexpected encoding error: %v", err) t.Fatalf("unexpected encoding error: %v", err)
} }
...@@ -110,9 +112,9 @@ func TestSetControllerConversion(t *testing.T) { ...@@ -110,9 +112,9 @@ func TestSetControllerConversion(t *testing.T) {
decoder := legacyscheme.Codecs.DecoderToVersion( decoder := legacyscheme.Codecs.DecoderToVersion(
legacyscheme.Codecs.UniversalDeserializer(), legacyscheme.Codecs.UniversalDeserializer(),
runtime.NewMultiGroupVersioner( runtime.NewMultiGroupVersioner(
*defaultGroup.GroupVersion(), defaultGroup,
schema.GroupKind{Group: defaultGroup.GroupVersion().Group}, schema.GroupKind{Group: defaultGroup.Group},
schema.GroupKind{Group: extGroup.GroupVersion().Group}, schema.GroupKind{Group: extGroup.Group},
), ),
) )
...@@ -122,7 +124,7 @@ func TestSetControllerConversion(t *testing.T) { ...@@ -122,7 +124,7 @@ func TestSetControllerConversion(t *testing.T) {
} }
t.Logf("rc._internal -> rc.v1") t.Logf("rc._internal -> rc.v1")
data, err = runtime.Encode(defaultGroup.Codec(), rc) data, err = runtime.Encode(defaultCodec, rc)
if err != nil { if err != nil {
t.Fatalf("unexpected encoding error: %v", err) t.Fatalf("unexpected encoding error: %v", err)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment