Merge pull request #50456 from liggitt/extra-steps

Automatic merge from submit-queue (batch tested with PRs 49488, 50407, 46105, 50456, 50258) Detect missing steps in edit testcases If a testcase specifies extra steps that are not exercised, that should be a test failure

Merge pull request #50456 from liggitt/extra-steps
d8070bd4 · Kubernetes Submit Queue · GitHub · b9b875f0 · 5a4ac692 · d8070bd4
Commit d8070bd4 authored Aug 11, 2017 by Kubernetes Submit Queue Committed by GitHub Aug 11, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

edit_test.go pkg/kubectl/cmd/edit_test.go +3 -0

No files found.
--- a/pkg/kubectl/cmd/edit_test.go
+++ b/pkg/kubectl/cmd/edit_test.go
@@ -280,6 +280,9 @@ func TestEdit(t *testing.T) {
 				t.Errorf("%s: expected to see '%s' in stderr\n\nstdout:\n%s\n\nstderr:\n%s", name, s, stdout, stderr)
 			}
 		}
+		if i < len(testcase.Steps) {
+			t.Errorf("%s: saw %d steps, testcase included %d additional steps that were not exercised", name, i, len(testcase.Steps)-i)
+		}
 	}
 }