Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
d6b46334
Commit
d6b46334
authored
Apr 07, 2015
by
Yu-Ju Hong
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unused code in kubelet/server_test.go
The code creates a channel and a go routine waiting for update, which is never used by any test. Remove the unused code.
parent
1ccfa589
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
32 deletions
+1
-32
kubelet_test.go
pkg/kubelet/kubelet_test.go
+0
-26
server_test.go
pkg/kubelet/server_test.go
+1
-6
No files found.
pkg/kubelet/kubelet_test.go
View file @
d6b46334
...
...
@@ -433,32 +433,6 @@ func TestKillContainer(t *testing.T) {
}
}
type
channelReader
struct
{
list
[][]
api
.
Pod
wg
sync
.
WaitGroup
}
func
startReading
(
channel
<-
chan
interface
{})
*
channelReader
{
cr
:=
&
channelReader
{}
cr
.
wg
.
Add
(
1
)
go
func
()
{
for
{
update
,
ok
:=
<-
channel
if
!
ok
{
break
}
cr
.
list
=
append
(
cr
.
list
,
update
.
(
PodUpdate
)
.
Pods
)
}
cr
.
wg
.
Done
()
}()
return
cr
}
func
(
cr
*
channelReader
)
GetList
()
[][]
api
.
Pod
{
cr
.
wg
.
Wait
()
return
cr
.
list
}
var
emptyPodUIDs
map
[
types
.
UID
]
metrics
.
SyncPodType
func
TestSyncPodsDoesNothing
(
t
*
testing
.
T
)
{
...
...
pkg/kubelet/server_test.go
View file @
d6b46334
...
...
@@ -112,18 +112,13 @@ func (fk *fakeKubelet) StreamingConnectionIdleTimeout() time.Duration {
}
type
serverTestFramework
struct
{
updateChan
chan
interface
{}
updateReader
*
channelReader
serverUnderTest
*
Server
fakeKubelet
*
fakeKubelet
testHTTPServer
*
httptest
.
Server
}
func
newServerTest
()
*
serverTestFramework
{
fw
:=
&
serverTestFramework
{
updateChan
:
make
(
chan
interface
{}),
}
fw
.
updateReader
=
startReading
(
fw
.
updateChan
)
fw
:=
&
serverTestFramework
{}
fw
.
fakeKubelet
=
&
fakeKubelet
{
podByNameFunc
:
func
(
namespace
,
name
string
)
(
*
api
.
Pod
,
bool
)
{
return
&
api
.
Pod
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment