Skip to content

K
k3s
Commit d661ea97 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #43432 from NickrenREN/vmmanager-cleanup

Automatic merge from submit-queue cleanup: remove TODO(resolved) and var(unused) **Release note**: ```release-note NONE ```
parents e3e44b77 a451daca
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 6 deletions
pkg/kubelet/volumemanager/volume_manager.go
View file @ d661ea97
...@@ -84,10 +84,6 @@ const ( ...@@ -84,10 +84,6 @@ const (
// operation is waiting it only blocks other operations on the same device, // operation is waiting it only blocks other operations on the same device,
// other devices are not affected. // other devices are not affected.
waitForAttachTimeout time.Duration = 10 * time.Minute waitForAttachTimeout time.Duration = 10 * time.Minute
// reconcilerStartGracePeriod is the maximum amount of time volume manager
// can wait to start reconciler
reconcilerStartGracePeriod time.Duration = 60 * time.Second
) )
// VolumeManager runs a set of asynchronous loops that figure out which volumes // VolumeManager runs a set of asynchronous loops that figure out which volumes
...@@ -123,8 +119,6 @@ type VolumeManager interface { ...@@ -123,8 +119,6 @@ type VolumeManager interface {
// attached to this node and remains "in use" until it is removed from both // attached to this node and remains "in use" until it is removed from both
// the desired state of the world and the actual state of the world, or it // the desired state of the world and the actual state of the world, or it
// has been unmounted (as indicated in actual state of world). // has been unmounted (as indicated in actual state of world).
// TODO(#27653): VolumesInUse should be handled gracefully on kubelet'
// restarts.
GetVolumesInUse() []v1.UniqueVolumeName GetVolumesInUse() []v1.UniqueVolumeName
// ReconcilerStatesHasBeenSynced returns true only after the actual states in reconciler // ReconcilerStatesHasBeenSynced returns true only after the actual states in reconciler
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment