Merge pull request #50135 from m1093782566/fed-apiserver-validation

federation/cmd/federation-apiserver/app/options/validation.go

@@ -16,6 +16,8 @@ limitations under the License.
 
 package options
 
+import "fmt"
+
 func (options *ServerRunOptions) Validate() []error {
 	var errors []error
 	if errs := options.Etcd.Validate(); len(errs) > 0 {
@@ -27,6 +29,27 @@ func (options *ServerRunOptions) Validate() []error {
 	if errs := options.InsecureServing.Validate("insecure-port"); len(errs) > 0 {
 		errors = append(errors, errs...)
 	}
+	if errs := options.Audit.Validate(); len(errs) > 0 {
+		errors = append(errors, errs...)
+	}
+	if errs := options.Features.Validate(); len(errs) > 0 {
+		errors = append(errors, errs...)
+	}
+	if errs := options.Admission.Validate(); len(errs) > 0 {
+		errors = append(errors, errs...)
+	}
+	if errs := options.Authentication.Validate(); len(errs) > 0 {
+		errors = append(errors, errs...)
+	}
+	if errs := options.Authorization.Validate(); len(errs) > 0 {
+		errors = append(errors, errs...)
+	}
+	if errs := options.CloudProvider.Validate(); len(errs) > 0 {
+		errors = append(errors, errs...)
+	}
+	if options.EventTTL <= 0 {
+		errors = append(errors, fmt.Errorf("--event-ttl must be greater than 0"))
+	}
 	// TODO: add more checks
 	return errors
 }

staging/src/k8s.io/apiserver/pkg/server/options/admission.go

@@ -89,3 +89,8 @@ func (a *AdmissionOptions) ApplyTo(serverCfg *server.Config, pluginInitializers
 	serverCfg.AdmissionControl = admissionChain
 	return nil
 }
+
+func (a *AdmissionOptions) Validate() []error {
+	errs := []error{}
+	return errs
+}

staging/src/k8s.io/apiserver/pkg/server/options/feature.go

@@ -55,3 +55,8 @@ func (o *FeatureOptions) ApplyTo(c *server.Config) error {
 
 	return nil
 }
+
+func (o *FeatureOptions) Validate() []error {
+	errs := []error{}
+	return errs
+}