Skip to content

K
k3s
Commit d2a45f0b authored by Alex Robinson's avatar Alex Robinson
Browse files
Options

Merge pull request #24909 from pmorie/security-context-loc

Reduce LOC in security context tests
parents 294e49f8 6f940a1a
Hide whitespace changes
Inline Side-by-side
Showing with 15 additions and 43 deletions
pkg/securitycontext/util_test.go
View file @ d2a45f0b
...@@ -84,6 +84,10 @@ func compareContexts(name string, ex, ac *api.SELinuxOptions, t *testing.T) { ...@@ -84,6 +84,10 @@ func compareContexts(name string, ex, ac *api.SELinuxOptions, t *testing.T) {
} }
} }
func containerWithUser(ptr *int64) *api.Container {
return &api.Container{SecurityContext: &api.SecurityContext{RunAsUser: ptr}}
}
func TestHaRootUID(t *testing.T) { func TestHaRootUID(t *testing.T) {
var nonRoot int64 = 1 var nonRoot int64 = 1
var root int64 = 0 var root int64 = 0
...@@ -96,26 +100,14 @@ func TestHaRootUID(t *testing.T) { ...@@ -96,26 +100,14 @@ func TestHaRootUID(t *testing.T) {
container: &api.Container{SecurityContext: nil}, container: &api.Container{SecurityContext: nil},
}, },
"nil runAsuser": { "nil runAsuser": {
container: &api.Container{ container: containerWithUser(nil),
SecurityContext: &api.SecurityContext{
RunAsUser: nil,
},
},
}, },
"runAsUser non-root": { "runAsUser non-root": {
container: &api.Container{ container: containerWithUser(&nonRoot),
SecurityContext: &api.SecurityContext{
RunAsUser: &nonRoot,
},
},
}, },
"runAsUser root": { "runAsUser root": {
container: &api.Container{ container: containerWithUser(&root),
SecurityContext: &api.SecurityContext{ expect: true,
RunAsUser: &root,
},
},
expect: true,
}, },
} }
...@@ -138,19 +130,11 @@ func TestHasRunAsUser(t *testing.T) { ...@@ -138,19 +130,11 @@ func TestHasRunAsUser(t *testing.T) {
container: &api.Container{SecurityContext: nil}, container: &api.Container{SecurityContext: nil},
}, },
"nil runAsUser": { "nil runAsUser": {
container: &api.Container{ container: containerWithUser(nil),
SecurityContext: &api.SecurityContext{
RunAsUser: nil,
},
},
}, },
"valid runAsUser": { "valid runAsUser": {
container: &api.Container{ container: containerWithUser(&runAsUser),
SecurityContext: &api.SecurityContext{ expect: true,
RunAsUser: &runAsUser,
},
},
expect: true,
}, },
} }
...@@ -174,26 +158,14 @@ func TestHasRootRunAsUser(t *testing.T) { ...@@ -174,26 +158,14 @@ func TestHasRootRunAsUser(t *testing.T) {
container: &api.Container{SecurityContext: nil}, container: &api.Container{SecurityContext: nil},
}, },
"nil runAsuser": { "nil runAsuser": {
container: &api.Container{ container: containerWithUser(nil),
SecurityContext: &api.SecurityContext{
RunAsUser: nil,
},
},
}, },
"runAsUser non-root": { "runAsUser non-root": {
container: &api.Container{ container: containerWithUser(&nonRoot),
SecurityContext: &api.SecurityContext{
RunAsUser: &nonRoot,
},
},
}, },
"runAsUser root": { "runAsUser root": {
container: &api.Container{ container: containerWithUser(&root),
SecurityContext: &api.SecurityContext{ expect: true,
RunAsUser: &root,
},
},
expect: true,
}, },
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment