Skip to content

K
k3s
Commit d1b44857 authored by saad-ali's avatar saad-ali
Browse files
Options

Add missing feature gate to CSI driver uninstall

parent 2b44ec5e
Show whitespace changes
Inline Side-by-side
Showing with 3 additions and 2 deletions
pkg/volume/csi/nodeinfomanager/nodeinfomanager.go
View file @ d1b44857
...@@ -133,13 +133,14 @@ func (nim *nodeInfoManager) InstallCSIDriver(driverName string, driverNodeID str ...@@ -133,13 +133,14 @@ func (nim *nodeInfoManager) InstallCSIDriver(driverName string, driverNodeID str
// If multiple calls to UninstallCSIDriver() are made in parallel, some calls might receive Node or // If multiple calls to UninstallCSIDriver() are made in parallel, some calls might receive Node or
// CSINodeInfo update conflicts, which causes the function to retry the corresponding update. // CSINodeInfo update conflicts, which causes the function to retry the corresponding update.
func (nim *nodeInfoManager) UninstallCSIDriver(driverName string) error { func (nim *nodeInfoManager) UninstallCSIDriver(driverName string) error {
// TODO: shouldn't this be feature gated? if utilfeature.DefaultFeatureGate.Enabled(features.CSINodeInfo) {
err := nim.uninstallDriverFromCSINodeInfo(driverName) err := nim.uninstallDriverFromCSINodeInfo(driverName)
if err != nil { if err != nil {
return fmt.Errorf("error uninstalling CSI driver from CSINodeInfo object %v", err) return fmt.Errorf("error uninstalling CSI driver from CSINodeInfo object %v", err)
} }
}
err = nim.updateNode( err := nim.updateNode(
removeMaxAttachLimit(driverName), removeMaxAttachLimit(driverName),
removeNodeIDFromNode(driverName), removeNodeIDFromNode(driverName),
) )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment