Skip to content

K
k3s
Commit cfdb4686 authored by k8s-merge-robot's avatar k8s-merge-robot Committed by GitHub
Browse files
Options

Merge pull request #29114 from matttproud/cleanups/density_e2e

Automatic merge from submit-queue test/e2e: plug time.Ticker resource leak. This commit ensures that `logPodStartupStatus` does not leak running `time.Ticker` instances. Upon termination of the consuming routine, we stop the ticker.
parents 33f96bbb 656ea8f9
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 0 deletions
test/e2e/density.go
View file @ cfdb4686
...@@ -151,6 +151,7 @@ func logPodStartupStatus(c *client.Client, expectedPods int, ns string, observed ...@@ -151,6 +151,7 @@ func logPodStartupStatus(c *client.Client, expectedPods int, ns string, observed
podStore := framework.NewPodStore(c, ns, label, fields.Everything()) podStore := framework.NewPodStore(c, ns, label, fields.Everything())
defer podStore.Stop() defer podStore.Stop()
ticker := time.NewTicker(period) ticker := time.NewTicker(period)
defer ticker.Stop()
for { for {
select { select {
case <-ticker.C: case <-ticker.C:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment