Unverified Commit ce68cfa4 authored by k8s-ci-robot's avatar k8s-ci-robot Committed by GitHub

Merge pull request #71428 from mkimuram/issue/71383

Fix subpath test flake that is caused in testPodFailSubpathError
parents 855f3fae 790de995
...@@ -1496,10 +1496,12 @@ func eventOccurred(c clientset.Interface, podName, namespace, eventSelector, msg ...@@ -1496,10 +1496,12 @@ func eventOccurred(c clientset.Interface, podName, namespace, eventSelector, msg
if err != nil { if err != nil {
return false, fmt.Errorf("got error while getting pod events: %s", err) return false, fmt.Errorf("got error while getting pod events: %s", err)
} }
if len(events.Items) == 0 { for _, event := range events.Items {
return false, nil // no events have occurred yet if strings.Contains(event.Message, msg) {
return true, nil
}
} }
return strings.Contains(events.Items[0].Message, msg), nil return false, nil
} }
} }
......
...@@ -587,8 +587,6 @@ func testPodFailSubpathError(f *framework.Framework, pod *v1.Pod, errorMsg strin ...@@ -587,8 +587,6 @@ func testPodFailSubpathError(f *framework.Framework, pod *v1.Pod, errorMsg strin
defer func() { defer func() {
framework.DeletePodWithWait(f, f.ClientSet, pod) framework.DeletePodWithWait(f, f.ClientSet, pod)
}() }()
err = framework.WaitForPodRunningInNamespace(f.ClientSet, pod)
Expect(err).To(HaveOccurred(), "while waiting for pod to be running")
By("Checking for subpath error event") By("Checking for subpath error event")
selector := fields.Set{ selector := fields.Set{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment