No need to pass GOFLAGS to $goflags variables.

In go 1.11, go commands will use `GOFLAGS` as default flags, see https://golang.org/doc/go1.11#go_command. There is no need to pass GOFLAGS to $goflags, and if we do, go commands will fail with "duplicate flags" error, e.g. ``` $ make test-integration WHAT=./test/integration/scheduler GOFLAGS="-v" ... go test: v flag may be set only once run "go help test" or "go help testflag" for more information ... ```

No need to pass GOFLAGS to $goflags variables.
ce22322e · Yecheng Fu · 7ba79c31 · ce22322e · ce22322e · ce22322e
Commit ce22322e authored Nov 19, 2018 by Yecheng Fu
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 6 deletions

golang.sh hack/lib/golang.sh +0 -2

test.sh hack/make-rules/test.sh +0 -1

vet.sh hack/make-rules/vet.sh +0 -3

No files found.
--- a/hack/lib/golang.sh
+++ b/hack/lib/golang.sh
@@ -677,9 +677,7 @@ kube::golang::build_binaries() {
    local host_platform
    host_platform=$(kube::golang::host_platform)
-    # Use eval to preserve embedded quoted strings.
    local goflags goldflags goasmflags gogcflags
-    eval "goflags=(${GOFLAGS:-})"
    goldflags="${GOLDFLAGS:-} -s -w $(kube::version::ldflags)"
    goasmflags="-trimpath=${KUBE_ROOT}"
    gogcflags="${GOGCFLAGS:-} -trimpath=${KUBE_ROOT}"

--- a/hack/make-rules/test.sh
+++ b/hack/make-rules/test.sh
@@ -171,7 +171,6 @@ done
 shift $((OPTIND - 1))
 # Use eval to preserve embedded quoted strings.
-eval "goflags=(${GOFLAGS:-})"
 eval "testargs=(${KUBE_TEST_ARGS:-})"
 # Used to filter verbose test output.

--- a/hack/make-rules/vet.sh
+++ b/hack/make-rules/vet.sh
@@ -35,9 +35,6 @@ fi
 # See https://github.com/golang/go/issues/16086 for details.
 go install ./cmd/...
-# Use eval to preserve embedded quoted strings.
-eval "goflags=(${GOFLAGS:-})"
 # Filter out arguments that start with "-" and move them to goflags.
 targets=()
 for arg; do