Skip to content

K
k3s
Commit cde7b584 authored by brendandburns's avatar brendandburns
Browse files
Options

Merge pull request #422 from claire921/use_splithostport

pkg/proxy: use net.SplitHostPort instead of strings.Split
parents ee4ec2af ba07dc80
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 4 deletions
pkg/proxy/roundrobbin.go
View file @ cde7b584
...@@ -23,7 +23,6 @@ import ( ...@@ -23,7 +23,6 @@ import (
"net" "net"
"reflect" "reflect"
"strconv" "strconv"
"strings"
"sync" "sync"
"github.com/GoogleCloudPlatform/kubernetes/pkg/api" "github.com/GoogleCloudPlatform/kubernetes/pkg/api"
...@@ -57,11 +56,11 @@ func (impl LoadBalancerRR) LoadBalance(service string, srcAddr net.Addr) (string ...@@ -57,11 +56,11 @@ func (impl LoadBalancerRR) LoadBalance(service string, srcAddr net.Addr) (string
} }
func (impl LoadBalancerRR) IsValid(spec string) bool { func (impl LoadBalancerRR) IsValid(spec string) bool {
index := strings.Index(spec, ":") _, port, err := net.SplitHostPort(spec)
if index == -1 { if err != nil {
return false return false
} }
value, err := strconv.Atoi(spec[index+1:]) value, err := strconv.Atoi(port)
if err != nil { if err != nil {
return false return false
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment