Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
ccd820d6
Unverified
Commit
ccd820d6
authored
May 02, 2018
by
Jordan Liggitt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
don't reuse resource builder in describe
parent
96a0df64
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
7 deletions
+7
-7
describe.go
pkg/kubectl/cmd/describe.go
+5
-5
builder.go
pkg/kubectl/resource/builder.go
+2
-2
No files found.
pkg/kubectl/cmd/describe.go
View file @
ccd820d6
...
...
@@ -73,8 +73,8 @@ type DescribeOptions struct {
Selector
string
Namespace
string
Describer
func
(
*
meta
.
RESTMapping
)
(
printers
.
Describer
,
error
)
Builder
*
resource
.
Builder
Describer
func
(
*
meta
.
RESTMapping
)
(
printers
.
Describer
,
error
)
NewBuilder
func
()
*
resource
.
Builder
BuilderArgs
[]
string
...
...
@@ -141,7 +141,7 @@ func (o *DescribeOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args [
o
.
BuilderArgs
=
args
o
.
Describer
=
f
.
Describer
o
.
Builder
=
f
.
NewBuilder
()
o
.
NewBuilder
=
f
.
NewBuilder
// include the uninitialized objects by default
// unless user explicitly set --include-uninitialized=false
...
...
@@ -154,7 +154,7 @@ func (o *DescribeOptions) Validate(args []string) error {
}
func
(
o
*
DescribeOptions
)
Run
()
error
{
r
:=
o
.
Builder
.
r
:=
o
.
NewBuilder
()
.
Unstructured
()
.
ContinueOnError
()
.
NamespaceParam
(
o
.
Namespace
)
.
DefaultNamespace
()
.
AllNamespaces
(
o
.
AllNamespaces
)
.
...
...
@@ -212,7 +212,7 @@ func (o *DescribeOptions) Run() error {
}
func
(
o
*
DescribeOptions
)
DescribeMatchingResources
(
originalError
error
,
resource
,
prefix
string
)
error
{
r
:=
o
.
Builder
.
r
:=
o
.
NewBuilder
()
.
Unstructured
()
.
NamespaceParam
(
o
.
Namespace
)
.
DefaultNamespace
()
.
ResourceTypeOrNameArgs
(
true
,
resource
)
.
...
...
pkg/kubectl/resource/builder.go
View file @
ccd820d6
...
...
@@ -198,7 +198,7 @@ func (b *Builder) Unstructured() *Builder {
b
.
errs
=
append
(
b
.
errs
,
fmt
.
Errorf
(
"no unstructured mapper provided"
))
return
b
}
if
b
.
mapper
!=
nil
{
if
b
.
mapper
!=
nil
&&
b
.
mapper
!=
b
.
unstructured
{
b
.
errs
=
append
(
b
.
errs
,
fmt
.
Errorf
(
"another mapper was already selected, cannot use unstructured types"
))
return
b
}
...
...
@@ -219,7 +219,7 @@ func (b *Builder) Internal(typer runtime.ObjectTyper) *Builder {
b
.
errs
=
append
(
b
.
errs
,
fmt
.
Errorf
(
"no internal mapper provided"
))
return
b
}
if
b
.
mapper
!=
nil
{
if
b
.
mapper
!=
nil
&&
b
.
mapper
!=
b
.
internal
{
b
.
errs
=
append
(
b
.
errs
,
fmt
.
Errorf
(
"another mapper was already selected, cannot use internal types"
))
return
b
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment