Commit caa935df authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #37442 from NickrenREN/kubelet-run

Automatic merge from submit-queue (batch tested with PRs 37094, 37663, 37442, 37808, 37826) fix if condition question in kubelet run() function Here variable err returned by function NewForConfig(&eventClientConfig) if CreateAPIServerClientConfig() function runs correctly . And we should not print "invalid kubeconfig" info. Should we use else instead of if.
parents ba62dafe 19c9860b
...@@ -392,8 +392,7 @@ func run(s *options.KubeletServer, kubeDeps *kubelet.KubeletDeps) (err error) { ...@@ -392,8 +392,7 @@ func run(s *options.KubeletServer, kubeDeps *kubelet.KubeletDeps) (err error) {
eventClientConfig.QPS = float32(s.EventRecordQPS) eventClientConfig.QPS = float32(s.EventRecordQPS)
eventClientConfig.Burst = int(s.EventBurst) eventClientConfig.Burst = int(s.EventBurst)
eventClient, err = clientset.NewForConfig(&eventClientConfig) eventClient, err = clientset.NewForConfig(&eventClientConfig)
} } else {
if err != nil {
if s.RequireKubeConfig { if s.RequireKubeConfig {
return fmt.Errorf("invalid kubeconfig: %v", err) return fmt.Errorf("invalid kubeconfig: %v", err)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment