Merge pull request #46761 from yastij/syncService-remove-copy

Automatic merge from submit-queue (batch tested with PRs 48106, 46761) removing unnecessary shallow copy on SyncService **What this PR does / why we need it**: remove shallow copy + avoid using same index name as the nested loop **Which issue this PR fixes**: fixes #46703 **Special notes for your reviewer**: **Release note**: ```release-note ```

Merge pull request #46761 from yastij/syncService-remove-copy
c30f5e1d · Kubernetes Submit Queue · GitHub · fd884b7e · b8781473 · c30f5e1d
Commit c30f5e1d authored Jun 27, 2017 by Kubernetes Submit Queue Committed by GitHub Jun 27, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 3 deletions

endpoints_controller.go pkg/controller/endpoint/endpoints_controller.go +1 -3

No files found.
--- a/pkg/controller/endpoint/endpoints_controller.go
+++ b/pkg/controller/endpoint/endpoints_controller.go
@@ -368,9 +368,7 @@ func (e *EndpointController) syncService(key string) error {
 	readyEps := 0
 	notReadyEps := 0
-	for i := range pods {
+	for _, pod := range pods {
-		// TODO: Do we need to copy here?
-		pod := &(*pods[i])
 		for i := range service.Spec.Ports {
 			servicePort := &service.Spec.Ports[i]