Merge pull request #42612 from CaoShuFeng/create_role_trival

Automatic merge from submit-queue add "bind" to validResourceVerbs in "create role" cli "bind" and "impersonate" are also a legal verbs according this: https://github.com/kubernetes/kubernetes.github.io/pull/2771/files **Release note**: ```NONE ```

Merge pull request #42612 from CaoShuFeng/create_role_trival
c2892866 · Kubernetes Submit Queue · GitHub · e0ba40b6 · 877bf544 · c2892866
Commit c2892866 authored Apr 22, 2017 by Kubernetes Submit Queue Committed by GitHub Apr 22, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 5 deletions

create_role.go pkg/kubectl/cmd/create_role.go +2 -2

create_role_test.go pkg/kubectl/cmd/create_role_test.go +4 -3

No files found.
--- a/pkg/kubectl/cmd/create_role.go
+++ b/pkg/kubectl/cmd/create_role.go
@@ -43,10 +43,10 @@ var (
 		kubectl create role pod-reader --verb=get --verb=list --verb=watch --resource=pods
 		# Create a Role named "pod-reader" with ResourceName specified
-		kubectl create role pod-reader --verb=get --verg=list --verb=watch --resource=pods --resource-name=readablepod`))
+		kubectl create role pod-reader --verb=get --verb=list --verb=watch --resource=pods --resource-name=readablepod`))
 	// Valid resource verb list for validation.
-	validResourceVerbs = []string{"*", "get", "delete", "list", "create", "update", "patch", "watch", "proxy", "redirect", "deletecollection", "use"}
+	validResourceVerbs = []string{"*", "get", "delete", "list", "create", "update", "patch", "watch", "proxy", "redirect", "deletecollection", "use", "bind", "impersonate"}
 )
 type CreateRoleOptions struct {

--- a/pkg/kubectl/cmd/create_role_test.go
+++ b/pkg/kubectl/cmd/create_role_test.go
@@ -203,11 +203,12 @@ func TestValidate(t *testing.T) {
 		},
 		"test-valid-case": {
 			roleOptions: &CreateRoleOptions{
-				Name:  "my-role",
+				Name:  "role-binder",
-				Verbs: []string{"get", "list"},
+				Verbs: []string{"get", "list", "bind"},
 				Resources: []schema.GroupVersionResource{
 					{
-						Resource: "pods",
+						Resource: "roles",
+						Group:    "rbac.authorization.k8s.io",
 					},
 				},
 				ResourceNames: []string{"foo"},