Skip to content

K
k3s
Commit c288f52d authored by Anthony Yeh's avatar Anthony Yeh
Browse files
Options

DaemonSet: Update Lister documentation for ControllerRef.

The DaemonSet Listers still use selectors, because this is the behavior expected by callers. This clarifies the meaning of the returned list. Some callers may need to switch to using GetControllerOf() instead, but that is a separate, case-by-case issue.
parent 10998118
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 6 deletions
pkg/client/listers/extensions/internalversion/daemonset_expansion.go
View file @ c288f52d
...@@ -35,8 +35,9 @@ type DaemonSetListerExpansion interface { ...@@ -35,8 +35,9 @@ type DaemonSetListerExpansion interface {
// DaemonSetNamespaeLister. // DaemonSetNamespaeLister.
type DaemonSetNamespaceListerExpansion interface{} type DaemonSetNamespaceListerExpansion interface{}
// GetPodDaemonSets returns a list of daemon sets managing a pod. // GetPodDaemonSets returns a list of DaemonSets that potentially match a pod.
// Returns an error if and only if no matching daemon sets are found. // Only the one specified in the Pod's ControllerRef will actually manage it.
// Returns an error only if no matching DaemonSets are found.
func (s *daemonSetLister) GetPodDaemonSets(pod *api.Pod) ([]*extensions.DaemonSet, error) { func (s *daemonSetLister) GetPodDaemonSets(pod *api.Pod) ([]*extensions.DaemonSet, error) {
var selector labels.Selector var selector labels.Selector
var daemonSet *extensions.DaemonSet var daemonSet *extensions.DaemonSet
......
pkg/client/listers/extensions/v1beta1/daemonset_expansion.go
View file @ c288f52d
...@@ -35,8 +35,9 @@ type DaemonSetListerExpansion interface { ...@@ -35,8 +35,9 @@ type DaemonSetListerExpansion interface {
// DaemonSetNamespaeLister. // DaemonSetNamespaeLister.
type DaemonSetNamespaceListerExpansion interface{} type DaemonSetNamespaceListerExpansion interface{}
// GetPodDaemonSets returns a list of daemon sets managing a pod. // GetPodDaemonSets returns a list of DaemonSets that potentially match a pod.
// Returns an error if and only if no matching daemon sets are found. // Only the one specified in the Pod's ControllerRef will actually manage it.
// Returns an error only if no matching DaemonSets are found.
func (s *daemonSetLister) GetPodDaemonSets(pod *v1.Pod) ([]*v1beta1.DaemonSet, error) { func (s *daemonSetLister) GetPodDaemonSets(pod *v1.Pod) ([]*v1beta1.DaemonSet, error) {
var selector labels.Selector var selector labels.Selector
var daemonSet *v1beta1.DaemonSet var daemonSet *v1beta1.DaemonSet
......
staging/src/k8s.io/client-go/listers/extensions/v1beta1/daemonset_expansion.go
View file @ c288f52d
...@@ -35,8 +35,9 @@ type DaemonSetListerExpansion interface { ...@@ -35,8 +35,9 @@ type DaemonSetListerExpansion interface {
// DaemonSetNamespaeLister. // DaemonSetNamespaeLister.
type DaemonSetNamespaceListerExpansion interface{} type DaemonSetNamespaceListerExpansion interface{}
// GetPodDaemonSets returns a list of daemon sets managing a pod. // GetPodDaemonSets returns a list of DaemonSets that potentially match a pod.
// Returns an error if and only if no matching daemon sets are found. // Only the one specified in the Pod's ControllerRef will actually manage it.
// Returns an error only if no matching DaemonSets are found.
func (s *daemonSetLister) GetPodDaemonSets(pod *v1.Pod) ([]*v1beta1.DaemonSet, error) { func (s *daemonSetLister) GetPodDaemonSets(pod *v1.Pod) ([]*v1beta1.DaemonSet, error) {
var selector labels.Selector var selector labels.Selector
var daemonSet *v1beta1.DaemonSet var daemonSet *v1beta1.DaemonSet
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment