Skip to content

K
k3s
Commit c1a40d80 authored by Clayton Coleman's avatar Clayton Coleman
Browse files
Options

Node controller did not handle an error

This means if List() fails nodes are considered deleted (which is bad)
parent a9277912
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 0 deletions
pkg/controller/node/nodecontroller.go
View file @ c1a40d80
...@@ -211,6 +211,9 @@ func (nc *NodeController) getCondition(status *api.NodeStatus, conditionType api ...@@ -211,6 +211,9 @@ func (nc *NodeController) getCondition(status *api.NodeStatus, conditionType api
// not reachable for a long period of time. // not reachable for a long period of time.
func (nc *NodeController) monitorNodeStatus() error { func (nc *NodeController) monitorNodeStatus() error {
nodes, err := nc.kubeClient.Nodes().List(labels.Everything(), fields.Everything()) nodes, err := nc.kubeClient.Nodes().List(labels.Everything(), fields.Everything())
if err != nil {
return err
}
for _, node := range nodes.Items { for _, node := range nodes.Items {
if !nc.knownNodeSet.Has(node.Name) { if !nc.knownNodeSet.Has(node.Name) {
glog.V(1).Infof("NodeController observed a new Node: %#v", node) glog.V(1).Infof("NodeController observed a new Node: %#v", node)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment