Merge pull request #73700 from denkensk/no-updae-timestamp-each-scheduling-attempt

Don't update the Pod object after each scheduling attempt

Merge pull request #73700 from denkensk/no-updae-timestamp-each-scheduling-attempt
bf3b5e55 · Kubernetes Prow Robot · GitHub · 9e4f8d6f · ea9e1a41 · bf3b5e55
Unverified Commit bf3b5e55 authored Feb 22, 2019 by Kubernetes Prow Robot Committed by GitHub Feb 22, 2019
Showing with 4 additions and 5 deletions

scheduling_queue.go pkg/scheduler/internal/queue/scheduling_queue.go +0 -0

scheduling_queue_test.go pkg/scheduler/internal/queue/scheduling_queue_test.go +0 -0

scheduler.go pkg/scheduler/scheduler.go +4 -5

No files found.
--- a/pkg/scheduler/internal/queue/scheduling_queue.go
+++ b/pkg/scheduler/internal/queue/scheduling_queue.go
--- a/pkg/scheduler/internal/queue/scheduling_queue_test.go
+++ b/pkg/scheduler/internal/queue/scheduling_queue_test.go
--- a/pkg/scheduler/scheduler.go
+++ b/pkg/scheduler/scheduler.go
@@ -265,11 +265,10 @@ func (sched *Scheduler) recordSchedulingFailure(pod *v1.Pod, err error, reason s
 	sched.config.Error(pod, err)
 	sched.config.Recorder.Event(pod, v1.EventTypeWarning, "FailedScheduling", message)
 	sched.config.PodConditionUpdater.Update(pod, &v1.PodCondition{
-		Type:          v1.PodScheduled,
+		Type:    v1.PodScheduled,
-		Status:        v1.ConditionFalse,
+		Status:  v1.ConditionFalse,
-		LastProbeTime: metav1.Now(),
+		Reason:  reason,
-		Reason:        reason,
+		Message: err.Error(),
-		Message:       err.Error(),
 	})
 }