Commit bd920de4 authored by Wojciech Tyczynski's avatar Wojciech Tyczynski

Avoid dumping all information in large clusters

parent 8f104a7b
...@@ -2264,9 +2264,21 @@ func DumpAllNamespaceInfo(c *client.Client, namespace string) { ...@@ -2264,9 +2264,21 @@ func DumpAllNamespaceInfo(c *client.Client, namespace string) {
// that if you delete a bunch of pods right before ending your test, // that if you delete a bunch of pods right before ending your test,
// you may or may not see the killing/deletion/Cleanup events. // you may or may not see the killing/deletion/Cleanup events.
dumpAllPodInfo(c) // If cluster is large, then the following logs are basically useless, because:
// 1. it takes tens of minutes or hours to grab all of them
dumpAllNodeInfo(c) // 2. there are so many of them that working with them are mostly impossible
// So we dump them only if the cluster is relatively small.
maxNodesForDump := 20
if nodes, err := c.Nodes().List(api.ListOptions{}); err == nil {
if len(nodes.Items) <= maxNodesForDump {
dumpAllPodInfo(c)
dumpAllNodeInfo(c)
} else {
Logf("skipping dumping cluster info - cluster too large")
}
} else {
Logf("unable to fetch node list: %v", err)
}
} }
// byFirstTimestamp sorts a slice of events by first timestamp, using their involvedObject's name as a tie breaker. // byFirstTimestamp sorts a slice of events by first timestamp, using their involvedObject's name as a tie breaker.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment