Fix flaky legacy pod autoscaler test

The reactor in runTest is set to catch all actions, but eventually it only handles CreateAction without checking action type which might fail sometimes when Patch arrives. This fix ensures we handle only the CreateAction.

Fix flaky legacy pod autoscaler test
bcfd48c2 · Maciej Szulik · 84b56103 · bcfd48c2
Unverified Commit bcfd48c2 authored Apr 05, 2019 by Maciej Szulik
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

legacy_horizontal_test.go pkg/controller/podautoscaler/legacy_horizontal_test.go +5 -1

No files found.
--- a/pkg/controller/podautoscaler/legacy_horizontal_test.go
+++ b/pkg/controller/podautoscaler/legacy_horizontal_test.go
@@ -472,7 +472,11 @@ func (tc *legacyTestCase) runTest(t *testing.T) {
 		if tc.finished {
 			return true, &v1.Event{}, nil
 		}
-		obj := action.(core.CreateAction).GetObject().(*v1.Event)
+		create, ok := action.(core.CreateAction)
+		if !ok {
+			return false, nil, nil
+		}
+		obj := create.GetObject().(*v1.Event)
 		if tc.verifyEvents {
 			switch obj.Reason {
 			case "SuccessfulRescale":