Merge pull request #50777 from apelisse/useful-error

Automatic merge from submit-queue (batch tested with PRs 49342, 50581, 50777) apimachinery: Print unknown transport type The current error message prints a pointer value rather than the actual type, which is really not useful. e.g.: ``` # Old: unknown transport type: &{0xc42044a7b0 0xc4208d6dc0} # New: unknown transport type: *gcp.conditionalTransport ``` **What this PR does / why we need it**: Makes an error message more useful. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: related to #50775 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```

Merge pull request #50777 from apelisse/useful-error
baa6b2ff · Kubernetes Submit Queue · GitHub · acd5f223 · d8d16a79 · baa6b2ff
Commit baa6b2ff authored Aug 16, 2017 by Kubernetes Submit Queue Committed by GitHub Aug 16, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

http.go staging/src/k8s.io/apimachinery/pkg/util/net/http.go +2 -2

No files found.
--- a/staging/src/k8s.io/apimachinery/pkg/util/net/http.go
+++ b/staging/src/k8s.io/apimachinery/pkg/util/net/http.go
@@ -108,7 +108,7 @@ func DialerFor(transport http.RoundTripper) (DialFunc, error) {
 	case RoundTripperWrapper:
 		return DialerFor(transport.WrappedRoundTripper())
 	default:
-		return nil, fmt.Errorf("unknown transport type: %v", transport)
+		return nil, fmt.Errorf("unknown transport type: %T", transport)
 	}
 }

@@ -129,7 +129,7 @@ func TLSClientConfig(transport http.RoundTripper) (*tls.Config, error) {
 	case RoundTripperWrapper:
 		return TLSClientConfig(transport.WrappedRoundTripper())
 	default:
-		return nil, fmt.Errorf("unknown transport type: %v", transport)
+		return nil, fmt.Errorf("unknown transport type: %T", transport)
 	}
 }