Skip to content

K
k3s
Commit b988eed2 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #34848 from deads2k/rbac-16-fix-authorization-filter

Automatic merge from submit-queue you can be authorized and have a failure Fix the authorization filter to allow you through and to avoid showing internal errors to users when authorization failed.
parents c32a0533 a8b47149
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 6 deletions
pkg/apiserver/filters/authorization.go
View file @ b988eed2
...@@ -40,16 +40,17 @@ func WithAuthorization(handler http.Handler, getAttribs RequestAttributeGetter, ...@@ -40,16 +40,17 @@ func WithAuthorization(handler http.Handler, getAttribs RequestAttributeGetter,
return return
} }
authorized, reason, err := a.Authorize(attrs) authorized, reason, err := a.Authorize(attrs)
if err != nil { if authorized {
internalError(w, req, err) handler.ServeHTTP(w, req)
return return
} }
if !authorized { if err != nil {
glog.V(4).Infof("Forbidden: %#v, Reason: %s", req.RequestURI, reason) internalError(w, req, err)
forbidden(w, req)
return return
} }
handler.ServeHTTP(w, req)
glog.V(4).Infof("Forbidden: %#v, Reason: %s", req.RequestURI, reason)
forbidden(w, req)
}) })
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment