Merge pull request #48589 from yiqinguo/yiqinguo_add_event

Automatic merge from submit-queue When faild create pod sandbox record event. I created pods because of the failure to create a sandbox, but there was no clear message telling me what was the failure, so I wanted to record an event when the sandbox was created. **Release note**: ```release-note NONE ```

Merge pull request #48589 from yiqinguo/yiqinguo_add_event
b8fde17f · Kubernetes Submit Queue · GitHub · 403ad595 · 798de294 · b8fde17f
Commit b8fde17f authored Aug 28, 2017 by Kubernetes Submit Queue Committed by GitHub Aug 28, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

event.go pkg/kubelet/events/event.go +1 -0

kuberuntime_manager.go pkg/kubelet/kuberuntime/kuberuntime_manager.go +5 -0

No files found.
--- a/pkg/kubelet/events/event.go
+++ b/pkg/kubelet/events/event.go
@@ -63,6 +63,7 @@ const (
 	SuccessfulNodeAllocatableEnforcement = "NodeAllocatableEnforced"
 	UnsupportedMountOption               = "UnsupportedMountOption"
 	SandboxChanged                       = "SandboxChanged"
+	FailedCreatePodSandBox               = "FailedCreatePodSandBox"

 	// Image manager event reason list
 	InvalidDiskCapacity = "InvalidDiskCapacity"

--- a/pkg/kubelet/kuberuntime/kuberuntime_manager.go
+++ b/pkg/kubelet/kuberuntime/kuberuntime_manager.go
@@ -607,6 +607,11 @@ func (m *kubeGenericRuntimeManager) SyncPod(pod *v1.Pod, _ v1.PodStatus, podStat
 		if err != nil {
 			createSandboxResult.Fail(kubecontainer.ErrCreatePodSandbox, msg)
 			glog.Errorf("createPodSandbox for pod %q failed: %v", format.Pod(pod), err)
+			ref, err := ref.GetReference(api.Scheme, pod)
+			if err != nil {
+				glog.Errorf("Couldn't make a ref to pod %q: '%v'", format.Pod(pod), err)
+			}
+			m.recorder.Eventf(ref, v1.EventTypeWarning, events.FailedCreatePodSandBox, "Failed create pod sandbox.")
 			return
 		}
 		glog.V(4).Infof("Created PodSandbox %q for pod %q", podSandboxID, format.Pod(pod))