Skip to content

K
k3s
Unverified Commit b692b715 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #62590 from mlmhl/csi_test

Automatic merge from submit-queue (batch tested with PRs 62590, 62818, 63015, 62922, 63000). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix some bugs inside CSI volume plugin unit test TestAttacherMountDevice **What this PR does / why we need it**: Fix two bugs inside CSI volume plugin unit test `TestAttacherMountDevice`. **Release note**: ```release-note None ```
parents b2ab9012 123ba1b4
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
pkg/volume/csi/csi_attacher_test.go
View file @ b692b715
...@@ -468,7 +468,7 @@ func TestAttacherMountDevice(t *testing.T) { ...@@ -468,7 +468,7 @@ func TestAttacherMountDevice(t *testing.T) {
devicePath: "", devicePath: "",
deviceMountPath: "path2", deviceMountPath: "path2",
stageUnstageSet: true, stageUnstageSet: true,
shouldFail: true, shouldFail: false,
}, },
{ {
testName: "no device mount path", testName: "no device mount path",
...@@ -533,7 +533,7 @@ func TestAttacherMountDevice(t *testing.T) { ...@@ -533,7 +533,7 @@ func TestAttacherMountDevice(t *testing.T) {
if !tc.shouldFail { if !tc.shouldFail {
t.Errorf("test should not fail, but error occurred: %v", err) t.Errorf("test should not fail, but error occurred: %v", err)
} }
return continue
} }
if err == nil && tc.shouldFail { if err == nil && tc.shouldFail {
t.Errorf("test should fail, but no error occurred") t.Errorf("test should fail, but no error occurred")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment