Commit b29023aa authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #30810 from mnshaw/gubernator-bugs

Automatic merge from submit-queue Gubernator bug fixes: mv and GCS bucket permissions Fixed issue where results file was not moved correctly, and also the permissions issue with the GCS bucket. Will rebase after #30414 is merged @timstclair
parents 96cbed4b f7e2109b
...@@ -79,6 +79,11 @@ fi ...@@ -79,6 +79,11 @@ fi
if [ $remote = true ] ; then if [ $remote = true ] ; then
# Setup the directory to copy test artifacts (logs, junit.xml, etc) from remote host to local host # Setup the directory to copy test artifacts (logs, junit.xml, etc) from remote host to local host
if [[ $gubernator = true && -d "${artifacts}" ]]; then
echo "Removing artifacts directory at ${artifacts}"
rm -r ${artifacts}
fi
if [ ! -d "${artifacts}" ]; then if [ ! -d "${artifacts}" ]; then
echo "Creating artifacts directory at ${artifacts}" echo "Creating artifacts directory at ${artifacts}"
mkdir -p ${artifacts} mkdir -p ${artifacts}
......
...@@ -58,11 +58,14 @@ V=2 kube::log::status "Using bucket ${bucket_name}" ...@@ -58,11 +58,14 @@ V=2 kube::log::status "Using bucket ${bucket_name}"
# Check if the bucket exists # Check if the bucket exists
if ! gsutil ls gs:// | grep -q "gs://${bucket_name}/"; then if ! gsutil ls gs:// | grep -q "gs://${bucket_name}/"; then
V=2 kube::log::status "Creating bucket ${bucket_name}" V=2 kube::log::status "Creating public bucket ${bucket_name}"
gsutil mb gs://${bucket_name}/ gsutil mb gs://${bucket_name}/
# Make all files in the bucket publicly readable
gsutil acl ch -u AllUsers:R gs://${bucket_name}
else else
V=2 kube::log::status "Bucket already exists" V=2 kube::log::status "Bucket already exists"
fi fi
# Path for e2e-node test results # Path for e2e-node test results
GCS_JOBS_PATH="gs://${bucket_name}/logs/e2e-node" GCS_JOBS_PATH="gs://${bucket_name}/logs/e2e-node"
...@@ -105,10 +108,11 @@ if gsutil ls "${GCS_JOBS_PATH}" | grep -q "${BUILD_STAMP}"; then ...@@ -105,10 +108,11 @@ if gsutil ls "${GCS_JOBS_PATH}" | grep -q "${BUILD_STAMP}"; then
exit exit
fi fi
results=$(find ${ARTIFACTS} -type d -name "results") for result in $(find ${ARTIFACTS} -type d -name "results"); do
if [[ $results != "" && $results != "${ARTIFACTS}/results" && $results != $ARTIFACTS ]]; then if [[ $result != "" && $result != "${ARTIFACTS}/results" && $result != $ARTIFACTS ]]; then
mv $results $ARTIFACTS mv $result/* $ARTIFACTS
fi fi
done
# Upload log files # Upload log files
for upload_attempt in $(seq 3); do for upload_attempt in $(seq 3); do
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment